scripts/slave/recipe_modules/v8/chromium_config.py - Issue 1412353002: WebRTC: Add Linux GCC bot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/v8/chromium_config.py

Issue 1412353002: WebRTC: Add Linux GCC bot. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Rename to gcc and add compiler group Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/v8/chromium_config.py

diff --git a/scripts/slave/recipe_modules/v8/chromium_config.py b/scripts/slave/recipe_modules/v8/chromium_config.py

index c2433376e083d08e84ac976e1d81fefcadeee02e..3ff74e3da394233ca1ad096d256bbd6acde45d54 100644

--- a/scripts/slave/recipe_modules/v8/chromium_config.py

+++ b/scripts/slave/recipe_modules/v8/chromium_config.py

@@ -87,7 +87,7 @@ def interpreted_regexp(c):

c.gyp_env.GYP_DEFINES['v8_interpreted_regexp'] = 1

-@CONFIG_CTX(group='builder')

+@CONFIG_CTX(includes=['v8'], group='builder')

def make(c):

c.build_dir = Path('[CHECKOUT]', 'out')

c.compile_py.build_tool = 'make'

@@ -103,11 +103,6 @@ def v8_ninja(c):

c.build_config_fs = c.BUILD_CONFIG + '_x64'

-@CONFIG_CTX(includes=['v8'])

-def no_clang(c):

- c.gyp_env.GYP_DEFINES['clang'] = 0

@CONFIG_CTX(includes=['v8', 'dcheck'])

def no_dcheck(c):

c.gyp_env.GYP_DEFINES['dcheck_always_on'] = 0