Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1412293006: Add AND(register) and AND(immediate) to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -2 lines) Patch
M src/DartARM32/assembler_arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 chunk +45 lines, -1 line 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/and.ll View 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Karl
5 years, 1 month ago (2015-10-29 21:48:56 UTC) #3
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-10-29 22:24:38 UTC) #4
Karl
5 years, 1 month ago (2015-10-29 22:50:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c33f7bbd4160a88aa95f81876b54e90edf982ca3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698