components/cronet/tools/cr_cronet.py - Issue 1412243012: Initial implementation of CronetBidirectionalStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 1412243012: Initial implementation of CronetBidirectionalStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Helen's comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java ('K') | « components/cronet/cronet_static.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/tools/cr_cronet.py

diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py

index 7d87b6ce4a0596d9c118c941283b193d9bd44a8a..0faaf560e119a3fc251cc9fc38f68af554fb275b 100755

--- a/components/cronet/tools/cr_cronet.py

+++ b/components/cronet/tools/cr_cronet.py

@@ -67,7 +67,8 @@ def main():

print options

print extra_options_list

gyp_defines = 'GYP_DEFINES="OS=android enable_websockets=0 '+ \

- 'disable_file_support=1 disable_ftp_support=1" '

+ 'disable_file_support=1 disable_ftp_support=1 '+ \

+ 'enable_bidirectional_stream=1"'

pauljensen 2016/01/04 19:56:01 hmm so buildbots won't be building this I guess?

mef 2016/01/04 22:27:08 Chrome build bots won't be building this as Chrome

out_dir = 'out/Debug'

release_arg = ''

extra_options = ' '.join(extra_options_list)

« components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java ('K') | « components/cronet/cronet_static.gypi ('k') | no next file » | no next file with comments »