components/cronet/cronet_static.gypi - Issue 1412243012: Initial implementation of CronetBidirectionalStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/cronet_static.gypi

Issue 1412243012: Initial implementation of CronetBidirectionalStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Helen's comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java ('K') | « components/cronet/android/test/javatests/src/org/chromium/net/TestBidirectionalStreamCallback.java ('k') | components/cronet/tools/cr_cronet.py » ('j') | components/cronet/tools/cr_cronet.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/cronet_static.gypi

diff --git a/components/cronet/cronet_static.gypi b/components/cronet/cronet_static.gypi

index 22d2a6f484873a60db1026e31d9c3b85431865ff..f8a4580ef63793fc581c18adb89e85c4c44fef2c 100644

--- a/components/cronet/cronet_static.gypi

+++ b/components/cronet/cronet_static.gypi

@@ -7,6 +7,7 @@

'dependencies': [

'../base/base.gyp:base',

'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',

+ 'cronet_features',

'cronet_jni_headers',

'cronet_url_request_java',

'cronet_version',

@@ -72,5 +73,15 @@

}

+ # If Bidirectional Stream support is enabled, add the following

+ # Dependencies are target-specific and are not included here.

+ ['enable_bidirectional_stream==1',

+ {

+ 'sources': [

+ 'android/cronet_bidirectional_stream.cc',

+ 'android/cronet_bidirectional_stream.h',

+ ],

+ }

+ ],

}