Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1412243005: win: Validate readability of memory ranges added to minidump (Closed)

Created:
5 years, 2 months ago by scottmg
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : rebase #

Patch Set 5 : . #

Total comments: 8

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -25 lines) Patch
M handler/handler.gyp View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A handler/win/self_destroying_test_program.cc View 1 2 3 4 5 1 chunk +97 lines, -0 lines 0 comments Download
M snapshot/win/end_to_end_test.py View 1 2 3 4 5 6 chunks +31 lines, -7 lines 0 comments Download
M snapshot/win/process_snapshot_win.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M snapshot/win/thread_snapshot_win.cc View 1 chunk +17 lines, -5 lines 0 comments Download
M util/win/process_info.h View 1 chunk +10 lines, -0 lines 0 comments Download
M util/win/process_info.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M util/win/process_info_test.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scottmg
5 years, 2 months ago (2015-10-21 22:43:05 UTC) #1
Mark Mentovai
LGTM https://codereview.chromium.org/1412243005/diff/80001/handler/win/self_destroying_test_program.cc File handler/win/self_destroying_test_program.cc (right): https://codereview.chromium.org/1412243005/diff/80001/handler/win/self_destroying_test_program.cc#newcode35 handler/win/self_destroying_test_program.cc:35: ProcessSuspensionState::kRunning)) { Align https://codereview.chromium.org/1412243005/diff/80001/handler/win/self_destroying_test_program.cc#newcode70 handler/win/self_destroying_test_program.cc:70: return 1; <stdlib.h> ...
5 years, 2 months ago (2015-10-21 22:49:29 UTC) #2
scottmg
https://codereview.chromium.org/1412243005/diff/80001/handler/win/self_destroying_test_program.cc File handler/win/self_destroying_test_program.cc (right): https://codereview.chromium.org/1412243005/diff/80001/handler/win/self_destroying_test_program.cc#newcode35 handler/win/self_destroying_test_program.cc:35: ProcessSuspensionState::kRunning)) { On 2015/10/21 22:49:29, Mark Mentovai wrote: > ...
5 years, 2 months ago (2015-10-21 22:58:08 UTC) #4
scottmg
5 years, 2 months ago (2015-10-21 23:07:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 (id:120001) manually as
90ef7475cdb131f56c23b494d4fe60b22138239e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698