win: Validate readability of memory ranges added to minidump

snapshot/win/process_snapshot_win.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 326 matching lines @@
     ReadLocks<Traits>(debug_critical_section_address, &extra_memory_);
 }
 
 void ProcessSnapshotWin::AddMemorySnapshot(
     WinVMAddress address,
     WinVMSize size,
     PointerVector<internal::MemorySnapshotWin>* into) {
   if (size == 0)
     return;
 
-  // Ensure that the entire range is readable. TODO(scottmg): Consider
-  // generalizing this as part of
-  // https://code.google.com/p/crashpad/issues/detail?id=59.
-  auto ranges = process_reader_.GetProcessInfo().GetReadableRanges(
-      CheckedRange<WinVMAddress, WinVMSize>(address, size));
-  if (ranges.size() != 1) {
-    LOG(ERROR) << base::StringPrintf(
-        "range at 0x%llx, size 0x%llx fully unreadable", address, size);
-    return;
-  }
-  if (ranges[0].base() != address || ranges[0].size() != size) {
-    LOG(ERROR) << base::StringPrintf(
-        "some of range at 0x%llx, size 0x%llx unreadable", address, size);
+  if (!process_reader_.GetProcessInfo().LoggingRangeIsFullyReadable(
+          CheckedRange<WinVMAddress, WinVMSize>(address, size))) {
     return;
   }
 
   // If we have already added this exact range, don't add it again. This is
   // useful for the LDR module lists which are a set of doubly-linked lists, all
   // pointing to the same module name strings.
   // TODO(scottmg): A more general version of this, handling overlapping,
   // contained, etc. https://code.google.com/p/crashpad/issues/detail?id=61.
   for (const auto& memory_snapshot : *into) {
     if (memory_snapshot->Address() == address &&
@@ skipping 152 matching lines @@
     // ProcessLocksList.Flink.
     current_address =
         critical_section_debug.ProcessLocksList.Flink -
         offsetof(process_types::RTL_CRITICAL_SECTION_DEBUG<Traits>,
                  ProcessLocksList);
   } while (current_address != start_address_forward &&
            current_address != kInvalid);
 }
 
 }  // namespace crashpad