Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: test/unittests/base/platform/condition-variable-unittest.cc

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-gap-resolver.cc ('k') | test/unittests/base/platform/semaphore-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/base/platform/condition-variable-unittest.cc
diff --git a/test/unittests/base/platform/condition-variable-unittest.cc b/test/unittests/base/platform/condition-variable-unittest.cc
index 26168d0223071d46fdf007f7c49e5b4a3a3a75b3..43fd33527092c8e8b197a7fb8dbe32568552947f 100644
--- a/test/unittests/base/platform/condition-variable-unittest.cc
+++ b/test/unittests/base/platform/condition-variable-unittest.cc
@@ -35,9 +35,8 @@ class ThreadWithMutexAndConditionVariable final : public Thread {
: Thread(Options("ThreadWithMutexAndConditionVariable")),
running_(false),
finished_(false) {}
- virtual ~ThreadWithMutexAndConditionVariable() {}
- virtual void Run() override {
+ void Run() override {
LockGuard<Mutex> lock_guard(&mutex_);
running_ = true;
cv_.NotifyOne();
@@ -116,9 +115,8 @@ class ThreadWithSharedMutexAndConditionVariable final : public Thread {
finished_(false),
cv_(NULL),
mutex_(NULL) {}
- virtual ~ThreadWithSharedMutexAndConditionVariable() {}
- virtual void Run() override {
+ void Run() override {
LockGuard<Mutex> lock_guard(mutex_);
running_ = true;
cv_->NotifyAll();
@@ -233,7 +231,7 @@ class LoopIncrementThread final : public Thread {
EXPECT_EQ(0, limit % thread_count);
}
- virtual void Run() override {
+ void Run() override {
int last_count = -1;
while (true) {
LockGuard<Mutex> lock_guard(mutex_);
« no previous file with comments | « test/cctest/compiler/test-gap-resolver.cc ('k') | test/unittests/base/platform/semaphore-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698