src/crankshaft/typing.h - Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/typing.h

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressing comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/typing.h

diff --git a/src/crankshaft/typing.h b/src/crankshaft/typing.h

index ddc562bcda9c8ce0eb52df57e2b1e22ee7bad0b5..d088b847092d1c8bc733b0ae4a31b331825ba00b 100644

--- a/src/crankshaft/typing.h

+++ b/src/crankshaft/typing.h

@@ -72,7 +72,7 @@ class AstTyper: public AstVisitor {

void VisitDeclarations(ZoneList<Declaration*>* declarations) override;

void VisitStatements(ZoneList<Statement*>* statements) override;

-#define DECLARE_VISIT(type) virtual void Visit##type(type* node) override;

+#define DECLARE_VISIT(type) void Visit##type(type* node) override;

AST_NODE_LIST(DECLARE_VISIT)

#undef DECLARE_VISIT

« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/elements.cc » ('j') | no next file with comments »