Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: src/code-stubs.h

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast-numbering.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 455ef1cc1e0dad2f673f7bf2a84d0075d98de452..29053d93054a0f268c7385aac378fb72b4ae832f 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -542,7 +542,7 @@ class TurboFanCodeStub : public CodeStub {
// Retrieve the code for the stub. Generate the code if needed.
Handle<Code> GenerateCode() override;
- virtual int GetStackParameterCount() const override {
+ int GetStackParameterCount() const override {
return GetCallInterfaceDescriptor().GetStackParameterCount();
}
@@ -633,9 +633,9 @@ class StubRuntimeCallHelper : public RuntimeCallHelper {
public:
StubRuntimeCallHelper() {}
- virtual void BeforeCall(MacroAssembler* masm) const;
+ void BeforeCall(MacroAssembler* masm) const override;
- virtual void AfterCall(MacroAssembler* masm) const;
+ void AfterCall(MacroAssembler* masm) const override;
};
@@ -644,9 +644,9 @@ class NopRuntimeCallHelper : public RuntimeCallHelper {
public:
NopRuntimeCallHelper() {}
- virtual void BeforeCall(MacroAssembler* masm) const {}
+ void BeforeCall(MacroAssembler* masm) const override {}
- virtual void AfterCall(MacroAssembler* masm) const {}
+ void AfterCall(MacroAssembler* masm) const override {}
};
@@ -2429,7 +2429,7 @@ class VectorKeyedStoreICStub : public PlatformCodeStub {
Code::Kind GetCodeKind() const final { return Code::KEYED_STORE_IC; }
InlineCacheState GetICState() const final { return GENERIC; }
- virtual ExtraICState GetExtraICState() const final {
+ ExtraICState GetExtraICState() const final {
return static_cast<ExtraICState>(minor_key_);
}
« no previous file with comments | « src/ast-numbering.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698