src/ast-literal-reindexer.h - Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast-literal-reindexer.h

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressing comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast-literal-reindexer.h

diff --git a/src/ast-literal-reindexer.h b/src/ast-literal-reindexer.h

index 9d48d21767dbd9585642b2bbe920fb8b4aeb461d..14f64f6ef18a43fbe9d4e550fd1e4251a33e3492 100644

--- a/src/ast-literal-reindexer.h

+++ b/src/ast-literal-reindexer.h

@@ -20,7 +20,7 @@ class AstLiteralReindexer final : public AstVisitor {

int NextIndex() { return next_index_++; }

private:

-#define DEFINE_VISIT(type) virtual void Visit##type(type* node) override;

+#define DEFINE_VISIT(type) void Visit##type(type* node) override;

AST_NODE_LIST(DEFINE_VISIT)

#undef DEFINE_VISIT

« no previous file with comments | « src/ast-expression-visitor.h ('k') | src/ast-numbering.cc » ('j') | no next file with comments »