Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1412223015: [turbofan] Fix receiver binding for inlined callees. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix receiver binding for inlined callees. This introduces a JSConvertReceiver operator to model the implicit conversion of receiver values for sloppy callees. It is used by the JSInliner for now, but can also be used to model direction function calls that bypass call stubs. Also note that a hint is passed to said operator whenever the source structure constrains the receiver value type. This hint allows for optimizations in the lowering of the operator. The underlying specification in ES6, section 9.2.1.2 is the basis for this implementation. R=bmeurer@chromium.org TEST=mjsunit/compiler/receiver-conversion BUG=v8:4493, v8:4470 LOG=n Committed: https://crrev.com/37f5e23b5c81ce45b1c7d79637f92ec4ceb16d3e Cr-Commit-Position: refs/heads/master@{#31598}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix compilation. #

Patch Set 3 : Fix for builtins. #

Patch Set 4 : Addressed comments. #

Total comments: 2

Patch Set 5 : Fix typos. #

Patch Set 6 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -25 lines) Patch
M src/compiler/ast-graph-builder.cc View 6 chunks +14 lines, -9 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/js-operator.h View 5 chunks +32 lines, -6 lines 0 comments Download
M src/compiler/js-operator.cc View 1 3 chunks +34 lines, -6 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/receiver-conversion.js View 1 2 3 4 1 chunk +128 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-10-27 10:55:49 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/1412223015/diff/1/src/compiler/js-operator.cc File src/compiler/js-operator.cc (right): https://codereview.chromium.org/1412223015/diff/1/src/compiler/js-operator.cc#newcode56 src/compiler/js-operator.cc:56: } Nit: UNREACHABLE(); return os; https://codereview.chromium.org/1412223015/diff/1/test/mjsunit/compiler/receiver-conversion.js File test/mjsunit/compiler/receiver-conversion.js (right): ...
5 years, 1 month ago (2015-10-27 11:24:42 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1412223015/diff/1/src/compiler/js-operator.cc File src/compiler/js-operator.cc (right): https://codereview.chromium.org/1412223015/diff/1/src/compiler/js-operator.cc#newcode56 src/compiler/js-operator.cc:56: } On 2015/10/27 11:24:42, Benedikt Meurer wrote: > Nit: ...
5 years, 1 month ago (2015-10-27 11:35:56 UTC) #3
Benedikt Meurer
LGTM with one final issue. https://codereview.chromium.org/1412223015/diff/60001/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1412223015/diff/60001/src/compiler/js-inlining.cc#newcode425 src/compiler/js-inlining.cc:425: if (is_sloppy(info.language_mode()) && !function->IsBuiltin()) ...
5 years, 1 month ago (2015-10-27 11:37:34 UTC) #4
Michael Starzinger
https://codereview.chromium.org/1412223015/diff/60001/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1412223015/diff/60001/src/compiler/js-inlining.cc#newcode425 src/compiler/js-inlining.cc:425: if (is_sloppy(info.language_mode()) && !function->IsBuiltin()) { On 2015/10/27 11:37:34, Benedikt ...
5 years, 1 month ago (2015-10-27 11:43:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223015/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223015/100001
5 years, 1 month ago (2015-10-27 12:08:27 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 1 month ago (2015-10-27 12:13:39 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 12:14:01 UTC) #10
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/37f5e23b5c81ce45b1c7d79637f92ec4ceb16d3e
Cr-Commit-Position: refs/heads/master@{#31598}

Powered by Google App Engine
This is Rietveld 408576698