Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/compiler/verifier.cc

Issue 1412223015: [turbofan] Fix receiver binding for inlined callees. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 // Type is Context, and operand is Internal. 559 // Type is Context, and operand is Internal.
560 Node* context = NodeProperties::GetContextInput(node); 560 Node* context = NodeProperties::GetContextInput(node);
561 // TODO(rossberg): This should really be Is(Internal), but the typer 561 // TODO(rossberg): This should really be Is(Internal), but the typer
562 // currently can't do backwards propagation. 562 // currently can't do backwards propagation.
563 CheckUpperMaybe(context, Type::Internal()); 563 CheckUpperMaybe(context, Type::Internal());
564 if (typing == TYPED) CHECK(NodeProperties::GetType(node)->IsContext()); 564 if (typing == TYPED) CHECK(NodeProperties::GetType(node)->IsContext());
565 break; 565 break;
566 } 566 }
567 567
568 case IrOpcode::kJSCallConstruct: 568 case IrOpcode::kJSCallConstruct:
569 case IrOpcode::kJSConvertReceiver:
569 // Type is Receiver. 570 // Type is Receiver.
570 CheckUpperIs(node, Type::Receiver()); 571 CheckUpperIs(node, Type::Receiver());
571 break; 572 break;
572 case IrOpcode::kJSCallFunction: 573 case IrOpcode::kJSCallFunction:
573 case IrOpcode::kJSCallRuntime: 574 case IrOpcode::kJSCallRuntime:
574 case IrOpcode::kJSYield: 575 case IrOpcode::kJSYield:
575 // Type can be anything. 576 // Type can be anything.
576 CheckUpperIs(node, Type::Any()); 577 CheckUpperIs(node, Type::Any());
577 break; 578 break;
578 579
(...skipping 631 matching lines...) Expand 10 before | Expand all | Expand 10 after
1210 replacement->op()->EffectOutputCount() > 0); 1211 replacement->op()->EffectOutputCount() > 0);
1211 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1212 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1212 replacement->opcode() == IrOpcode::kFrameState); 1213 replacement->opcode() == IrOpcode::kFrameState);
1213 } 1214 }
1214 1215
1215 #endif // DEBUG 1216 #endif // DEBUG
1216 1217
1217 } // namespace compiler 1218 } // namespace compiler
1218 } // namespace internal 1219 } // namespace internal
1219 } // namespace v8 1220 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698