Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1412223009: Reland: GpuMemoryBuffer interface change: Map(**) to Map() and memory(plane); stride(plane) (Closed)

Created:
5 years, 2 months ago by mcasas
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, danakj+watch_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, sievers+watch_chromium.org, ben+mojo_chromium.org, darin (slow to review), miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: GpuMemoryBuffer interface change: Map(**) to Map() and memory(plane); stride(plane) Relanding http://crrev.com/1401183003 which had a compile error. Original reviewers: TBR=avi@chromium.org, bajones@chromium.org, reveman@chromium.org, dalecurtis@chromium.org, fsamuel@chromium.org, miu@chromium.org Original CL description:----------------------------------- GpuMemoryBuffer interface change: Map(**) --> Map() + memory(plane); GetStride(*) --> stride(plane) And at the same time clean up/simplify/homogeneise uses of those APIs. buffer_format_util.cc:RowSizeForBufferFormatChecked() is only used in unittests and internally to the file, this CL restricts it to the .cc file. Also a function there is only used in test --> added ForTesting() suffix. BUG=542225 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a11ca23b4ae411b4dc6cd8ff755e366680e80776 Cr-Commit-Position: refs/heads/master@{#355396} Committed: https://crrev.com/89b86777fe6b6e2b9ef8089faf9d1378ce2db184 Cr-Commit-Position: refs/heads/master@{#355630}

Patch Set 1 #

Patch Set 2 : Win X64 compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -356 lines) Patch
M cc/raster/one_copy_tile_task_worker_pool.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.cc View 1 chunk +12 lines, -13 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.cc View 2 chunks +11 lines, -16 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer.cc View 1 2 chunks +12 lines, -16 lines 0 comments Download
M content/browser/compositor/buffer_queue_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 7 chunks +15 lines, -17 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M content/child/child_thread_impl_browsertest.cc View 2 chunks +13 lines, -17 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.cc View 2 chunks +17 lines, -4 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h View 3 chunks +6 lines, -5 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc View 3 chunks +19 lines, -18 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M content/test/gpu_memory_buffer_factory_test_template.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu_memory_buffer_impl_test_template.h View 5 chunks +39 lines, -59 lines 0 comments Download
M gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc View 1 chunk +8 lines, -13 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 2 chunks +18 lines, -15 lines 0 comments Download
M media/renderers/mock_gpu_video_accelerator_factories.cc View 4 chunks +21 lines, -11 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M ui/gfx/buffer_format_util.h View 2 chunks +7 lines, -8 lines 0 comments Download
M ui/gfx/buffer_format_util.cc View 4 chunks +91 lines, -56 lines 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 2 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223009/20001
5 years, 2 months ago (2015-10-22 18:38:20 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-22 20:18:36 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 20:19:39 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89b86777fe6b6e2b9ef8089faf9d1378ce2db184
Cr-Commit-Position: refs/heads/master@{#355630}

Powered by Google App Engine
This is Rietveld 408576698