Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1412223007: Ship Notification action buttons by default (Closed)

Created:
5 years, 2 months ago by johnme
Modified:
5 years, 1 month ago
CC:
blink-reviews, chromium-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@notexp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship Notification action buttons by default Intent to ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/8iSlPpwokbY/discussion BUG=513671, 513672, 548297 Committed: https://crrev.com/2a381fb7a46742b05d199c6614624b1bf1432ebb Cr-Commit-Position: refs/heads/master@{#358304}

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 19 (11 generated)
johnme
5 years, 2 months ago (2015-10-21 17:16:34 UTC) #2
Peter Beverloo
lgtm % intent to ship passing Please link to the Intent to Ship in your ...
5 years, 1 month ago (2015-10-29 14:32:54 UTC) #4
dglazkov
lgtm
5 years, 1 month ago (2015-11-05 18:28:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223007/20001
5 years, 1 month ago (2015-11-05 18:33:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/140910)
5 years, 1 month ago (2015-11-05 18:44:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223007/20001
5 years, 1 month ago (2015-11-06 10:26:54 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 11:26:05 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 11:26:59 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a381fb7a46742b05d199c6614624b1bf1432ebb
Cr-Commit-Position: refs/heads/master@{#358304}

Powered by Google App Engine
This is Rietveld 408576698