Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.idl

Issue 1412223007: Ship Notification action buttons by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notexp
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/Notification.idl
diff --git a/third_party/WebKit/Source/modules/notifications/Notification.idl b/third_party/WebKit/Source/modules/notifications/Notification.idl
index 38297e74b27acdeda4f67b1ee89abb536e2cc672..b985e3db1a107d90252d4794f385f64834c1bb7a 100644
--- a/third_party/WebKit/Source/modules/notifications/Notification.idl
+++ b/third_party/WebKit/Source/modules/notifications/Notification.idl
@@ -53,7 +53,7 @@ enum NotificationPermission {
[CallWith=ScriptState, Exposed=Window, MeasureAs=NotificationPermissionRequested] static Promise<NotificationPermission> requestPermission(optional NotificationPermissionCallback deprecatedCallback);
- [RuntimeEnabled=NotificationExperimental] static readonly attribute unsigned long maxActions;
+ static readonly attribute unsigned long maxActions;
attribute EventHandler onclick;
[MeasureAs=NotificationShowEvent] attribute EventHandler onshow;
@@ -72,7 +72,9 @@ enum NotificationPermission {
readonly attribute boolean requireInteraction;
[CallWith=ScriptState, SameObject] readonly attribute any data;
- // TODO(johnme): The spec requires a FrozenArray, but sequence seems to behave like one already?! https://crbug.com/515920
+ // TODO(johnme): Ship once Blink supports FrozenArray (https://crbug.com/515920)
+ // and we've implemented the additional Object.freeze described in
+ // https://notifications.spec.whatwg.org/#dom-notification-actions
[RuntimeEnabled=NotificationExperimental] readonly attribute sequence<NotificationAction> actions;
[MeasureAs=NotificationClosed] void close();

Powered by Google App Engine
This is Rietveld 408576698