Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1412223004: [Contextual Search] Fix Content visibility regression. (Closed)

Created:
5 years, 2 months ago by pedro (no code reviews)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Fix Content visibility regression. BUG=545604 BUG=545608 Committed: https://crrev.com/449c5aa0e9ab9cc209c1d1b72b34df93ad5e56bb Cr-Commit-Position: refs/heads/master@{#355146}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 10 (3 generated)
pedro (no code reviews)
Hey guys, please take a look at this change. It fixes a recently introduced regression ...
5 years, 2 months ago (2015-10-20 19:11:16 UTC) #3
Donn Denman
lgtm
5 years, 2 months ago (2015-10-20 20:32:44 UTC) #4
aurimas (slooooooooow)
LGTM. Developers usually list affected bugs with a single line like: BUG=545604,545608 https://chromiumcodereview.appspot.com/1412223004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java ...
5 years, 2 months ago (2015-10-20 20:45:01 UTC) #5
pedro (no code reviews)
https://codereview.chromium.org/1412223004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java (left): https://codereview.chromium.org/1412223004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java#oldcode35 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java:35: private static final long INTERCEPT_NAVIGATION_PROMOTION_ANIMATION_DURATION_MS = 40; On 2015/10/20 ...
5 years, 2 months ago (2015-10-20 20:47:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223004/1
5 years, 2 months ago (2015-10-20 20:51:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 20:57:51 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 20:58:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/449c5aa0e9ab9cc209c1d1b72b34df93ad5e56bb
Cr-Commit-Position: refs/heads/master@{#355146}

Powered by Google App Engine
This is Rietveld 408576698