Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3834)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java

Issue 1412223004: [Contextual Search] Fix Content visibility regression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
index 5479a3b81b2e714555107f304df1960296a7ec95..2ae5c4b5ab43b3c969d77e251957ad5fad4d1a50 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
@@ -11,8 +11,6 @@ import android.view.View.MeasureSpec;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.compositor.bottombar.OverlayContentProgressObserver;
import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel;
-import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.PanelState;
-import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelContent;
import org.chromium.chrome.browser.compositor.layouts.ChromeAnimation;
import org.chromium.chrome.browser.compositor.layouts.LayoutUpdateHost;
@@ -28,13 +26,6 @@ public class ContextualSearchPanel extends OverlayPanel
implements ContextualSearchPanelDelegate {
/**
- * The animation duration of a URL being promoted to a tab when triggered by an
- * intercept navigation. This is faster than the standard tab promotion animation
- * so that it completes before the navigation.
- */
- private static final long INTERCEPT_NAVIGATION_PROMOTION_ANIMATION_DURATION_MS = 40;
aurimas (slooooooooow) 2015/10/20 20:45:01 Is this removal related to the rest of the patch?
pedro (no code reviews) 2015/10/20 20:47:46 No, I just noticed this was not being used. This w
-
- /**
* The extra dp added around the close button touch target.
*/
private static final int CLOSE_BUTTON_TOUCH_SLOP_DP = 5;
@@ -751,4 +742,9 @@ public class ContextualSearchPanel extends OverlayPanel
public void notifyPanelTouched() {
getOverlayPanelContent().notifyPanelTouched();
}
+
+ @Override
+ public void destroyContent() {
+ super.destroyOverlayPanelContent();
+ }
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698