Issue 14122010: NaCl: Enable untrusted hardware exception handling by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14122010: NaCl: Enable untrusted hardware exception handling by default (Closed)

Created:
7 years, 8 months ago by Mark Seaborn

Modified:
7 years, 8 months ago

Reviewers:
bradn

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Enable untrusted hardware exception handling by default I'm leaving in NaClProcessHost's enable_exception_handling_ field because we will want to disable exception handling under PNaCl. BUG=https://code.google.com/p/nativeclient/issues/detail?id=2401 TEST=inbrowser_test_runner in nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194537

Patch Set 1 #

Patch Set 2 : Update translation file #

Patch Set 3 : Remove env var #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -30 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/nacl_host/nacl_process_host.cc	View		2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ppapi/native_client/tests/nacl_browser/inbrowser_test_runner/nacl.scons	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

7 years, 8 months ago (2013-04-17 05:08:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r194537 (presubmit successful).

Expand Messages | Collapse Messages