Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5116)

Unified Diff: chrome/browser/nacl_host/nacl_process_host.cc

Issue 14122010: NaCl: Enable untrusted hardware exception handling by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove env var Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/nacl_host/nacl_process_host.cc
diff --git a/chrome/browser/nacl_host/nacl_process_host.cc b/chrome/browser/nacl_host/nacl_process_host.cc
index bada69a052f468748ca33ea3a1347b5277cf6abd..f91bd4e66d25b3d82a7a85266342df9753ac8640 100644
--- a/chrome/browser/nacl_host/nacl_process_host.cc
+++ b/chrome/browser/nacl_host/nacl_process_host.cc
@@ -196,7 +196,7 @@ NaClProcessHost::NaClProcessHost(const GURL& manifest_url,
#endif
internal_(new NaClInternal()),
ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
- enable_exception_handling_(false),
+ enable_exception_handling_(true),
enable_debug_stub_(false),
uses_irt_(uses_irt),
off_the_record_(off_the_record),
@@ -211,13 +211,6 @@ NaClProcessHost::NaClProcessHost(const GURL& manifest_url,
// for this use case.
process_->SetName(net::FormatUrl(manifest_url_, std::string()));
- // We allow untrusted hardware exception handling to be enabled via
- // an env var for consistency with the standalone build of NaCl.
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableNaClExceptionHandling) ||
- getenv("NACL_UNTRUSTED_EXCEPTION_HANDLING") != NULL) {
- enable_exception_handling_ = true;
- }
enable_debug_stub_ = CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableNaClDebug);
}
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698