Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 1412193009: Fix bug in allowInteropCaptureThis that caused JavaScript objects to accidentally be wrapped. (Closed)

Created:
5 years, 2 months ago by Jacob
Modified:
5 years, 2 months ago
Reviewers:
sra, sra1, kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bug in allowInteropCaptureThis that caused JavaScript objects to accidentally be wrapped. Remove spurious call to _convertToJS BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/ff200c11fad63dcbdc9f34645fb23eb2e949f14f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/js_typed_interop_test.dart View 6 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jacob
5 years, 2 months ago (2015-10-20 22:44:32 UTC) #2
sra1
lgtm
5 years, 2 months ago (2015-10-21 18:01:19 UTC) #4
Jacob
Committed patchset #1 (id:1) manually as ff200c11fad63dcbdc9f34645fb23eb2e949f14f (presubmit successful).
5 years, 2 months ago (2015-10-21 18:12:16 UTC) #5
kevmoo
Need a merge request for 1.13, right?
5 years, 2 months ago (2015-10-21 19:19:55 UTC) #7
schultz.t.dan
On 2015/10/21 19:19:55, kevmoo wrote: > Need a merge request for 1.13, right? Did these ...
5 years, 2 months ago (2015-10-22 19:55:03 UTC) #8
kevmoo
5 years, 2 months ago (2015-10-22 19:57:29 UTC) #9
Message was sent while issue was closed.
On 2015/10/22 19:55:03, schultz.t.dan wrote:
> On 2015/10/21 19:19:55, kevmoo wrote:
> > Need a merge request for 1.13, right?
> 
> Did these changes go out in 1.13.0-dev.7.2?

https://github.com/dart-lang/sdk/commit/6261f84277782b93e9cd8fca84aa480f3c4b6b6d

Nope. You'll have to wait for .7.3 (the .7.2 release commit message is wrong)

Powered by Google App Engine
This is Rietveld 408576698