sdk/lib/js/dart2js/js_dart2js.dart - Issue 1412193009: Fix bug in allowInteropCaptureThis that caused JavaScript objects to accidentally be wrapped.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/js/dart2js/js_dart2js.dart

Issue 1412193009: Fix bug in allowInteropCaptureThis that caused JavaScript objects to accidentally be wrapped. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/js/dart2js/js_dart2js.dart

diff --git a/sdk/lib/js/dart2js/js_dart2js.dart b/sdk/lib/js/dart2js/js_dart2js.dart

index 417876e5738a9a246e767ab7454883f0b1c45ad9..f98b29d73cc69548c8d3a5ea0cc78df6b5588000 100644

--- a/sdk/lib/js/dart2js/js_dart2js.dart

+++ b/sdk/lib/js/dart2js/js_dart2js.dart

@@ -704,7 +704,7 @@ _callDartFunctionFast(callback, List arguments) {

}

_callDartFunctionFastCaptureThis(callback, self, List arguments) {

- return _convertToJS(Function.apply(callback, [self]..addAll(arguments)));

+ return Function.apply(callback, [self]..addAll(arguments));

}

Function allowInterop(Function f) {

« no previous file with comments | « no previous file | tests/html/js_typed_interop_test.dart » ('j') | no next file with comments »