Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1412173006: Properly recreate swapped out RenderView. (Closed)

Created:
5 years, 2 months ago by nasko
Modified:
5 years, 1 month ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly recreate swapped out RenderView. This CL fixes how RenderView is recreated after a process crash. Due to not recreating the RenderFrameProxy in the case the RenderView is swapped out, the WebView ends up with no mainFrame() and crashes in various ways. This is a reland of https://codereview.chromium.org/1408743005/ with the refactoring portion committed separately in https://codereview.chromium.org/1415303002/. BUG=357747, 544271 Committed: https://crrev.com/2fd02526ca100834b7a2b13304203244670d7bb3 Cr-Commit-Position: refs/heads/master@{#355802}

Patch Set 1 #

Patch Set 2 : Rebase on top of refactor. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 chunks +2 lines, -2 lines 1 comment Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nasko
Hey Charlie, This is a reland of a CL you already reviewed. It should be ...
5 years, 1 month ago (2015-10-22 23:48:10 UTC) #3
Charlie Reis
LGTM.
5 years, 1 month ago (2015-10-22 23:54:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412173006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412173006/20001
5 years, 1 month ago (2015-10-23 15:17:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-23 16:41:51 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-23 16:42:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fd02526ca100834b7a2b13304203244670d7bb3
Cr-Commit-Position: refs/heads/master@{#355802}

Powered by Google App Engine
This is Rietveld 408576698