Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412083007: Remove FastAllocBase.h (Closed)

Created:
5 years, 1 month ago by haraken
Modified:
5 years, 1 month ago
Reviewers:
hajimehoshi, sof, tasak
CC:
chromium-reviews, szager+layoutwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, tzik, webcomponents-bugzilla_chromium.org, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, shans, apavlov+blink_chromium.org, kinuko+worker_chromium.org, rjwright, blink-reviews-wtf_chromium.org, kouhei+svg_chromium.org, rwlbuis, caseq+blink_chromium.org, krit, drott+blinkwatch_chromium.org, toyoshim+midi_chromium.org, yhirano+watch_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, danakj, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, blink-worker-reviews_chromium.org, Eric Willigers, philipj_slow, vmpstr+blinkwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-paint_chromium.org, blink-reviews-layout_chromium.org, sof, jbroman, lushnikov+blink_chromium.org, Raymond Toy, loading-reviews_chromium.org, tommyw+watchlist_chromium.org, pdr+graphicswatchlist_chromium.org, nhiroki, darktears, loading-reviews+fetch_chromium.org, Nate Chapin, Stephen Chennney, mkwst+watchlist-csp_chromium.org, tyoshino+watch_chromium.org, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, tfarina, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, falken, pfeldman+blink_chromium.org, f(malita), blink-reviews-animation_chromium.org, horo+watch_chromium.org, sergeyv+blink_chromium.org, Mikhail, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FastAllocBase.h All allocator-related macros should be placed in Allocator.h. To that end, this CL moves WTF_MAKE_FAST_ALLOCATED to Allocator.h. And removes FastAllocBase.h. BUG=548217 Committed: https://crrev.com/f3e3c8a1b03a03a9124f02ad0329eeb41cdb15ca Cr-Commit-Position: refs/heads/master@{#356628}

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -178 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/CustomElementBinding.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ModuleProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RetainedObjectInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/Init.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentOrderedList.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContextTask.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MainThreadTaskRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TransformSource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceClient.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameViewAutoSizeInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/LinkManifest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputTypeView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportsController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/imports/LinkImport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InjectedScriptHostClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTaskRunner.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/RemoteObjectId.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8Debugger.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ClipRect.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutAnalyzer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResources.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTracker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoaderClient.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/NetworkStateNotifier.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/CompositingRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FloatClipRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/LayerFixedPositionRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/CachedUAStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/DataRef.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/GridCoordinate.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathConsumer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/SharedBufferReader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeysClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileSystemClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/PermissionCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNodeInput.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteTransaction.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/AsyncFileSystemCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/AsyncMethodRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/HostWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Length.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDSPKernel.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/IntRect.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Color.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Path.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FixedPositionDisplayItem.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/transforms/AffineTransform.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/transforms/TransformationMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHelperPluginImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Allocator.h View 2 chunks +56 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/DefaultAllocator.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/wtf/FastAllocBase.h View 1 chunk +0 lines, -90 lines 0 comments Download
M third_party/WebKit/Source/wtf/LinkedStack.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/PrintStream.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/RefCounted.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArray.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ThreadSafeRefCounted.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingPrimitives.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/Collator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
haraken
PTAL
5 years, 1 month ago (2015-10-28 18:07:36 UTC) #2
sof
lgtm Bunch of redundant includes noticed while looking through. https://codereview.chromium.org/1412083007/diff/1/third_party/WebKit/Source/core/dom/DocumentOrderedList.h File third_party/WebKit/Source/core/dom/DocumentOrderedList.h (right): https://codereview.chromium.org/1412083007/diff/1/third_party/WebKit/Source/core/dom/DocumentOrderedList.h#newcode32 third_party/WebKit/Source/core/dom/DocumentOrderedList.h:32: ...
5 years, 1 month ago (2015-10-28 18:29:59 UTC) #4
haraken
> Bunch of redundant includes noticed while looking through. > > https://codereview.chromium.org/1412083007/diff/1/third_party/WebKit/Source/core/dom/DocumentOrderedList.h > File third_party/WebKit/Source/core/dom/DocumentOrderedList.h ...
5 years, 1 month ago (2015-10-28 18:49:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412083007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412083007/20001
5 years, 1 month ago (2015-10-28 18:50:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-28 20:24:52 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 20:25:33 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f3e3c8a1b03a03a9124f02ad0329eeb41cdb15ca
Cr-Commit-Position: refs/heads/master@{#356628}

Powered by Google App Engine
This is Rietveld 408576698