Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411983006: Merge to XFA: Fix incorrect paths in third_party.gyp. (Closed)

Created:
5 years, 1 month ago by Oliver Chang
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix incorrect paths in third_party.gyp. Also, reorder the freetype srcs. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1431863006 . (cherry picked from commit f1a7cd8c489e75abff7a2e952ea52f92142a5b88) Committed: https://pdfium.googlesource.com/pdfium/+/b3a8c21f42a588f80a849566bed6bcb1a82a50c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/third_party.gyp View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Oliver Chang
TBR. clean merge.
5 years, 1 month ago (2015-11-06 18:19:20 UTC) #1
Oliver Chang
Committed patchset #1 (id:1) manually as b3a8c21f42a588f80a849566bed6bcb1a82a50c6 (presubmit successful).
5 years, 1 month ago (2015-11-06 18:19:49 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-11-06 18:27:27 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698