Issue 1431863006: Fix incorrect paths in third_party.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1431863006: Fix incorrect paths in third_party.gyp. (Closed)

Created:
5 years, 1 month ago by Oliver Chang

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	third_party/third_party.gyp	View		3 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 5 (1 generated)

Oliver Chang

ptal, simple change. not sure why gyp_pdfium gave a warning on Windows but not on ...

5 years, 1 month ago (2015-11-06 17:19:28 UTC) #2

Lei Zhang

lgtm, but double check to make sure it is correct in the .gn file as ...

5 years, 1 month ago (2015-11-06 18:08:22 UTC) #3

Oliver Chang

On 2015/11/06 18:08:22, Lei Zhang wrote: > lgtm, but double check to make sure it ...

5 years, 1 month ago (2015-11-06 18:16:57 UTC) #4

Oliver Chang

5 years, 1 month ago (2015-11-06 18:17:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f1a7cd8c489e75abff7a2e952ea52f92142a5b88 (presubmit successful).