Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: ui/aura/window.cc

Issue 1411833006: Refactoring to make adding ink drop animations easier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactor ink drop animations (comments in ui/views/) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/window.cc
diff --git a/ui/aura/window.cc b/ui/aura/window.cc
index c97941d1fd5e22665576b95301209b6264ef0a1e..ca597bec5fd052cad21dc7fd4ec3dee55a99e261 100644
--- a/ui/aura/window.cc
+++ b/ui/aura/window.cc
@@ -93,7 +93,7 @@ Window::Window(WindowDelegate* delegate)
// problems for code that adds an observer as part of an observer
// notification (such as the workspace code).
observers_(base::ObserverList<WindowObserver>::NOTIFY_EXISTING_ONLY) {
- set_target_handler(delegate_);
+ ignore_result(SetTargetHandler(delegate_));
sadrul 2015/11/25 22:38:58 We shouldn't need to use ignore_result(), since Se
varkha 2015/11/26 00:05:46 Done.
}
Window::~Window() {
@@ -109,7 +109,7 @@ Window::~Window() {
// While we are being destroyed, our target handler may also be in the
// process of destruction or already destroyed, so do not forward any
// input events at the ui::EP_TARGET phase.
- set_target_handler(nullptr);
+ ignore_result(SetTargetHandler(nullptr));
sadrul 2015/11/25 22:38:58 ditto
varkha 2015/11/26 00:05:46 Done.
// TODO(beng): See comment in window_event_dispatcher.h. This shouldn't be
// necessary but unfortunately is right now due to ordering

Powered by Google App Engine
This is Rietveld 408576698