Refactoring to make adding ink drop animations easier

ui/aura/window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/window.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 75 matching lines @@
       parent_(NULL),
       visible_(false),
       id_(-1),
       transparent_(false),
       user_data_(NULL),
       ignore_events_(false),
       // Don't notify newly added observers during notification. This causes
       // problems for code that adds an observer as part of an observer
       // notification (such as the workspace code).
       observers_(base::ObserverList<WindowObserver>::NOTIFY_EXISTING_ONLY) {
-  set_target_handler(delegate_);
+  ignore_result(SetTargetHandler(delegate_));

[sadrul, 2015/11/25 22:38:58]

We shouldn't need to use ignore_result(), since SetTargetHandler() doesn't
WARN_UNUSED_RESULT?

[varkha, 2015/11/26 00:05:46]

Done.

 }
 
 Window::~Window() {
   if (layer()->owner() == this)
     layer()->CompleteAllAnimations();
   layer()->SuppressPaint();
 
   // Let the delegate know we're in the processing of destroying.
   if (delegate_)
     delegate_->OnWindowDestroying(this);
   FOR_EACH_OBSERVER(WindowObserver, observers_, OnWindowDestroying(this));
 
   // While we are being destroyed, our target handler may also be in the
   // process of destruction or already destroyed, so do not forward any
   // input events at the ui::EP_TARGET phase.
-  set_target_handler(nullptr);
+  ignore_result(SetTargetHandler(nullptr));

[sadrul, 2015/11/25 22:38:58]

ditto

[varkha, 2015/11/26 00:05:46]

Done.

 
   // TODO(beng): See comment in window_event_dispatcher.h. This shouldn't be
   //             necessary but unfortunately is right now due to ordering
   //             peculiarities. WED must be notified _after_ other observers
   //             are notified of pending teardown but before the hierarchy
   //             is actually torn down.
   WindowTreeHost* host = GetHost();
   if (host)
     host->dispatcher()->OnPostNotifiedWindowDestroying(this);
 
@@ skipping 985 matching lines @@
     layer_name = "Unnamed Window";
 
   if (id_ != -1)
     layer_name += " " + base::IntToString(id_);
 
   layer()->set_name(layer_name);
 #endif
 }
 
 }  // namespace aura