Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: minidump/minidump_handle_writer.h

Issue 1411793005: Pool TypeName strings when writing MINIDUMP_HANDLE_DESCRIPTOR (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@handle-write
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | minidump/minidump_handle_writer.cc » ('j') | minidump/minidump_handle_writer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_handle_writer.h
diff --git a/minidump/minidump_handle_writer.h b/minidump/minidump_handle_writer.h
index 592456b96160fc227b8340db3f2ab40dac9c2493..f2e5f0a50f6ad97d48b5de5584024e38e0c9e9f9 100644
--- a/minidump/minidump_handle_writer.h
+++ b/minidump/minidump_handle_writer.h
@@ -18,13 +18,13 @@
#include <windows.h>
#include <dbghelp.h>
+#include <map>
#include <vector>
#include "minidump/minidump_stream_writer.h"
#include "minidump/minidump_string_writer.h"
#include "minidump/minidump_writable.h"
#include "snapshot/handle_snapshot.h"
-#include "util/stdlib/pointer_container.h"
namespace crashpad {
@@ -65,7 +65,7 @@ class MinidumpHandleDataWriter final : public internal::MinidumpStreamWriter {
private:
MINIDUMP_HANDLE_DATA_STREAM handle_data_stream_base_;
std::vector<MINIDUMP_HANDLE_DESCRIPTOR> handle_descriptors_;
- PointerVector<internal::MinidumpUTF16StringWriter> strings_;
+ std::map<base::string16, internal::MinidumpUTF16StringWriter*> strings_;
DISALLOW_COPY_AND_ASSIGN(MinidumpHandleDataWriter);
};
« no previous file with comments | « no previous file | minidump/minidump_handle_writer.cc » ('j') | minidump/minidump_handle_writer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698