Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: minidump/minidump_handle_writer.h

Issue 1411793005: Pool TypeName strings when writing MINIDUMP_HANDLE_DESCRIPTOR (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@handle-write
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | minidump/minidump_handle_writer.cc » ('j') | minidump/minidump_handle_writer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #ifndef CRASHPAD_MINIDUMP_MINIDUMP_HANDLE_WRITER_H_ 15 #ifndef CRASHPAD_MINIDUMP_MINIDUMP_HANDLE_WRITER_H_
16 #define CRASHPAD_MINIDUMP_MINIDUMP_HANDLE_WRITER_H_ 16 #define CRASHPAD_MINIDUMP_MINIDUMP_HANDLE_WRITER_H_
17 17
18 #include <windows.h> 18 #include <windows.h>
19 #include <dbghelp.h> 19 #include <dbghelp.h>
20 20
21 #include <map>
21 #include <vector> 22 #include <vector>
22 23
23 #include "minidump/minidump_stream_writer.h" 24 #include "minidump/minidump_stream_writer.h"
24 #include "minidump/minidump_string_writer.h" 25 #include "minidump/minidump_string_writer.h"
25 #include "minidump/minidump_writable.h" 26 #include "minidump/minidump_writable.h"
26 #include "snapshot/handle_snapshot.h" 27 #include "snapshot/handle_snapshot.h"
27 #include "util/stdlib/pointer_container.h"
28 28
29 namespace crashpad { 29 namespace crashpad {
30 30
31 //! \brief The writer for a MINIDUMP_HANDLE_DATA_STREAM stream in a minidump 31 //! \brief The writer for a MINIDUMP_HANDLE_DATA_STREAM stream in a minidump
32 //! and its contained MINIDUMP_HANDLE_DESCRIPTOR s. 32 //! and its contained MINIDUMP_HANDLE_DESCRIPTOR s.
33 //! 33 //!
34 //! As we currently do not track any data beyond what MINIDUMP_HANDLE_DESCRIPTOR 34 //! As we currently do not track any data beyond what MINIDUMP_HANDLE_DESCRIPTOR
35 //! supports, we only write that type of record rather than the newer 35 //! supports, we only write that type of record rather than the newer
36 //! MINIDUMP_HANDLE_DESCRIPTOR_2. 36 //! MINIDUMP_HANDLE_DESCRIPTOR_2.
37 //! 37 //!
(...skipping 20 matching lines...) Expand all
58 size_t SizeOfObject() override; 58 size_t SizeOfObject() override;
59 std::vector<MinidumpWritable*> Children() override; 59 std::vector<MinidumpWritable*> Children() override;
60 bool WriteObject(FileWriterInterface* file_writer) override; 60 bool WriteObject(FileWriterInterface* file_writer) override;
61 61
62 // MinidumpStreamWriter: 62 // MinidumpStreamWriter:
63 MinidumpStreamType StreamType() const override; 63 MinidumpStreamType StreamType() const override;
64 64
65 private: 65 private:
66 MINIDUMP_HANDLE_DATA_STREAM handle_data_stream_base_; 66 MINIDUMP_HANDLE_DATA_STREAM handle_data_stream_base_;
67 std::vector<MINIDUMP_HANDLE_DESCRIPTOR> handle_descriptors_; 67 std::vector<MINIDUMP_HANDLE_DESCRIPTOR> handle_descriptors_;
68 PointerVector<internal::MinidumpUTF16StringWriter> strings_; 68 std::map<base::string16, internal::MinidumpUTF16StringWriter*> strings_;
69 69
70 DISALLOW_COPY_AND_ASSIGN(MinidumpHandleDataWriter); 70 DISALLOW_COPY_AND_ASSIGN(MinidumpHandleDataWriter);
71 }; 71 };
72 72
73 } // namespace crashpad 73 } // namespace crashpad
74 74
75 #endif // CRASHPAD_MINIDUMP_MINIDUMP_HANDLE_WRITER_H_ 75 #endif // CRASHPAD_MINIDUMP_MINIDUMP_HANDLE_WRITER_H_
OLDNEW
« no previous file with comments | « no previous file | minidump/minidump_handle_writer.cc » ('j') | minidump/minidump_handle_writer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698