Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1411743004: GN: Add nacl_arm_glibc toolchain (Closed)

Created:
5 years, 2 months ago by Roland McGrath
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke, Petr Hosek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add nacl_arm_glibc toolchain This adds a toolchain definition for NaCl's ARM glibc toolchain. Nothing uses this yet. Once this lands, changes in the native_client repo will be required to start using it. BUG=512901 R=dpranke@chromium.org, phosek@chromium.org Committed: https://crrev.com/ab949d7831e67970d671352cf7815b4e52c93b9b Cr-Commit-Position: refs/heads/master@{#355398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -24 lines) Patch
M build/toolchain/nacl/BUILD.gn View 2 chunks +38 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Roland McGrath
5 years, 2 months ago (2015-10-21 20:08:03 UTC) #1
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-21 20:10:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411743004/1
5 years, 2 months ago (2015-10-21 20:14:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 21:06:55 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 21:07:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab949d7831e67970d671352cf7815b4e52c93b9b
Cr-Commit-Position: refs/heads/master@{#355398}

Powered by Google App Engine
This is Rietveld 408576698