Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1411733009: Bulk rename files in chrome/browser/ui/cocoa/passwords/ (Closed)

Created:
5 years, 1 month ago by vasilii
Modified:
5 years, 1 month ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-federation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bulk rename files in chrome/browser/ui/cocoa/passwords/ Delete ManageCredentialItemViewController because it's unused. BUG=400674 Committed: https://crrev.com/9ab7500f50a83d8b192d666e5ef499445ca55c6b Cr-Commit-Position: refs/heads/master@{#357244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -3797 lines) Patch
M chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/auto_signin_view_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/auto_signin_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_credential_item_view_controller.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_credential_item_view_controller.mm View 1 chunk +0 lines, -219 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_credential_item_view_controller_unittest.mm View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.mm View 1 chunk +0 lines, -504 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller_unittest.mm View 1 chunk +0 lines, -199 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.mm View 1 chunk +0 lines, -276 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller_unittest.mm View 1 chunk +0 lines, -204 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_auto_signin_view_controller.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_auto_signin_view_controller.mm View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_browsertest.mm View 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.h View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa_unittest.mm View 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm View 1 chunk +0 lines, -145 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller_unittest.mm View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_content_view_controller.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_content_view_controller.mm View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm View 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller_unittest.mm View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller.mm View 1 chunk +0 lines, -187 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller_unittest.mm View 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm View 1 chunk +0 lines, -240 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller_unittest.mm View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_controller_test.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_controller_test.mm View 1 chunk +0 lines, -46 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/passwords_bubble_browsertest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/passwords_list_view_controller_unittest.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/pending_password_view_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/passwords/pending_password_view_controller_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +18 lines, -20 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 3 chunks +11 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
vasilii
Hi Rachel, I renamed most of the files in chrome/browser/ui/cocoa/passwords/. As I edit them quite ...
5 years, 1 month ago (2015-10-30 11:18:00 UTC) #2
groby-ooo-7-16
On 2015/10/30 11:18:00, vasilii wrote: > Hi Rachel, > > I renamed most of the ...
5 years, 1 month ago (2015-10-30 23:37:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411733009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411733009/1
5 years, 1 month ago (2015-10-30 23:39:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-31 00:55:58 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-31 00:56:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ab7500f50a83d8b192d666e5ef499445ca55c6b
Cr-Commit-Position: refs/heads/master@{#357244}

Powered by Google App Engine
This is Rietveld 408576698