Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller_unittest.mm

Issue 1411733009: Bulk rename files in chrome/browser/ui/cocoa/passwords/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-federation
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller_unittest.mm
deleted file mode 100644
index 5ecd0806acbbaa70bc9aa0c2d392b0cfb3df148e..0000000000000000000000000000000000000000
--- a/chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller_unittest.mm
+++ /dev/null
@@ -1,199 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#import "chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.h"
-
-#include "base/mac/foundation_util.h"
-#include "base/mac/scoped_nsobject.h"
-#include "base/strings/string16.h"
-#include "base/strings/sys_string_conversions.h"
-#include "chrome/browser/password_manager/password_store_factory.h"
-#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
-#import "chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.h"
-#include "chrome/browser/ui/cocoa/passwords/manage_passwords_controller_test.h"
-#import "chrome/browser/ui/cocoa/passwords/password_item_views.h"
-#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
-#include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h"
-#include "components/password_manager/core/browser/mock_password_store.h"
-#include "components/password_manager/core/browser/password_manager_test_utils.h"
-#include "components/password_manager/core/browser/password_store.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "testing/gtest_mac.h"
-
-using namespace testing;
-
-namespace {
-NSString* const kItemTestUsername = @"foo";
-NSString* const kItemTestPassword = @"bar";
-NSString* const kFederation = @"https://google.com/idp";
-} // namespace
-
-class PasswordsListViewControllerTest : public ManagePasswordsControllerTest {
- public:
- PasswordsListViewControllerTest() {}
-
- void SetUp() override {
- ManagePasswordsControllerTest::SetUp();
- PasswordStoreFactory::GetInstance()->SetTestingFactory(
- profile(),
- password_manager::BuildPasswordStoreService<
- content::BrowserContext, password_manager::MockPasswordStore>);
- }
-
- void SetUpManageState(
- const std::vector<const autofill::PasswordForm*>& forms) {
- model()->set_state(password_manager::ui::MANAGE_STATE);
- controller_.reset([[PasswordsListViewController alloc]
- initWithModel:model()
- forms:forms]);
- }
-
- void SetUpManageState(const autofill::PasswordForm* form) {
- model()->set_state(password_manager::ui::PENDING_PASSWORD_STATE);
- controller_.reset([[PasswordsListViewController alloc]
- initWithModel:model()
- forms:std::vector<const autofill::PasswordForm*>(1, form)]);
- }
-
- ManagePasswordItemViewController* GetControllerAt(unsigned i) {
- return base::mac::ObjCCast<ManagePasswordItemViewController>(
- [[controller_ itemViews] objectAtIndex:i]);
- }
-
- autofill::PasswordForm local_credential() {
- autofill::PasswordForm form;
- form.username_value = base::SysNSStringToUTF16(kItemTestUsername);
- form.password_value = base::SysNSStringToUTF16(kItemTestPassword);
- return form;
- }
-
- autofill::PasswordForm federated_credential() {
- autofill::PasswordForm form;
- form.username_value = base::SysNSStringToUTF16(kItemTestUsername);
- form.federation_url = GURL(base::SysNSStringToUTF16(kFederation));
- return form;
- }
-
- password_manager::MockPasswordStore* mockStore() {
- password_manager::PasswordStore* store =
- PasswordStoreFactory::GetForProfile(profile(),
- ServiceAccessType::EXPLICIT_ACCESS)
- .get();
- return static_cast<password_manager::MockPasswordStore*>(store);
- }
-
- private:
- base::scoped_nsobject<PasswordsListViewController> controller_;
-
- DISALLOW_COPY_AND_ASSIGN(PasswordsListViewControllerTest);
-};
-
-TEST_F(PasswordsListViewControllerTest, ManageStateShouldHaveManageView) {
- ScopedVector<const autofill::PasswordForm> forms;
- forms.push_back(new autofill::PasswordForm(local_credential()));
- forms.push_back(new autofill::PasswordForm(federated_credential()));
- SetUpManageState(forms.get());
-
- EXPECT_EQ(MANAGE_PASSWORD_ITEM_STATE_MANAGE, [GetControllerAt(0) state]);
- EXPECT_EQ(MANAGE_PASSWORD_ITEM_STATE_MANAGE, [GetControllerAt(1) state]);
- EXPECT_NSEQ([ManagePasswordItemView class],
- [[GetControllerAt(0) contentView] class]);
- EXPECT_NSEQ([ManagePasswordItemView class],
- [[GetControllerAt(1) contentView] class]);
-}
-
-TEST_F(PasswordsListViewControllerTest,
- ClickingDeleteShouldShowUndoViewAndDeletePassword) {
- ScopedVector<const autofill::PasswordForm> forms;
- forms.push_back(new autofill::PasswordForm(local_credential()));
- SetUpManageState(forms.get());
-
- ManagePasswordItemView* manageView =
- base::mac::ObjCCast<ManagePasswordItemView>(
- [GetControllerAt(0) contentView]);
- EXPECT_CALL(*mockStore(), RemoveLogin(local_credential()));
- [manageView.deleteButton performClick:nil];
-
- EXPECT_NSEQ([UndoPasswordItemView class],
- [[GetControllerAt(0) contentView] class]);
-}
-
-TEST_F(PasswordsListViewControllerTest,
- ClickingUndoShouldShowManageViewAndAddPassword) {
- ScopedVector<const autofill::PasswordForm> forms;
- forms.push_back(new autofill::PasswordForm(local_credential()));
- SetUpManageState(forms.get());
-
- ManagePasswordItemView* manageView =
- base::mac::ObjCCast<ManagePasswordItemView>(
- [GetControllerAt(0) contentView]);
- EXPECT_CALL(*mockStore(), RemoveLogin(local_credential()));
- [manageView.deleteButton performClick:nil];
-
- UndoPasswordItemView* undoView = base::mac::ObjCCast<UndoPasswordItemView>(
- [GetControllerAt(0) contentView]);
- EXPECT_CALL(*mockStore(), AddLogin(local_credential()));
- [undoView.undoButton performClick:nil];
-
- EXPECT_NSEQ([ManagePasswordItemView class],
- [[GetControllerAt(0) contentView] class]);
-}
-
-TEST_F(PasswordsListViewControllerTest,
- ManageViewShouldHaveCorrectUsernameAndObscuredPassword) {
- ScopedVector<const autofill::PasswordForm> forms;
- forms.push_back(new autofill::PasswordForm(local_credential()));
- forms.push_back(new autofill::PasswordForm(federated_credential()));
- SetUpManageState(forms.get());
- ManagePasswordItemView* manageView =
- base::mac::ObjCCast<ManagePasswordItemView>(
- [GetControllerAt(0) contentView]);
-
- // Ensure the fields are populated properly and the password is obscured.
- EXPECT_NSEQ(kItemTestUsername, manageView.usernameField.stringValue);
- EXPECT_NSEQ(kItemTestPassword, manageView.passwordField.stringValue);
- EXPECT_TRUE([[manageView.passwordField cell] echosBullets]);
-
- manageView = base::mac::ObjCCast<ManagePasswordItemView>(
- [GetControllerAt(1) contentView]);
- EXPECT_NSEQ(kItemTestUsername, manageView.usernameField.stringValue);
- EXPECT_THAT(base::SysNSStringToUTF8(manageView.passwordField.stringValue),
- HasSubstr(federated_credential().federation_url.host()));
-}
-
-TEST_F(PasswordsListViewControllerTest, PendingStateShouldHavePendingView) {
- autofill::PasswordForm form = local_credential();
- SetUpManageState(&form);
- EXPECT_EQ(MANAGE_PASSWORD_ITEM_STATE_PENDING, [GetControllerAt(0) state]);
- EXPECT_NSEQ([PendingPasswordItemView class],
- [[GetControllerAt(0) contentView] class]);
-}
-
-TEST_F(PasswordsListViewControllerTest,
- PendingViewShouldHaveCorrectUsernameAndObscuredPassword) {
- autofill::PasswordForm form = local_credential();
- SetUpManageState(&form);
- PendingPasswordItemView* pendingView =
- base::mac::ObjCCast<PendingPasswordItemView>(
- [GetControllerAt(0) contentView]);
-
- // Ensure the fields are populated properly and the password is obscured.
- EXPECT_NSEQ(kItemTestUsername, pendingView.usernameField.stringValue);
- EXPECT_NSEQ(kItemTestPassword, pendingView.passwordField.stringValue);
- EXPECT_TRUE([[pendingView.passwordField cell] echosBullets]);
-}
-
-TEST_F(PasswordsListViewControllerTest,
- PendingViewShouldHaveCorrectUsernameAndFederation) {
- autofill::PasswordForm form = federated_credential();
- SetUpManageState(&form);
- PendingPasswordItemView* pendingView =
- base::mac::ObjCCast<PendingPasswordItemView>(
- [GetControllerAt(0) contentView]);
-
- // Ensure the fields are populated properly and the password is obscured.
- EXPECT_NSEQ(kItemTestUsername, pendingView.usernameField.stringValue);
- EXPECT_THAT(base::SysNSStringToUTF8(pendingView.passwordField.stringValue),
- HasSubstr(federated_credential().federation_url.host()));
-}

Powered by Google App Engine
This is Rietveld 408576698