Pass Thread into StackFrameIterator

Pass Thread into StackFrameIterator

- StackFrameIterator is now constructed with a Thread instead of an Isolate.
- Profiler provides Thread to StackFrameIterator- allowing this to work on Windows.

R=asiva@google.com, srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/24ceded4e9412483ee557afab30ec570a02ec11f

[Cutch, 2015-10-20 20:50:50]

Description was changed from

==========
Pass Thread into StackFrameIterator

BUG=
==========

to

==========
Pass Thread into StackFrameIterator

BUG=
==========

[Cutch, 2015-10-20 20:50:50]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com, srdjan@google.com

[srdjan, 2015-10-20 20:59:26]

https://codereview.chromium.org/1411703004/diff/1/runtime/vm/stack_frame.h
File runtime/vm/stack_frame.h (right):

https://codereview.chromium.org/1411703004/diff/1/runtime/vm/stack_frame.h#ne...
runtime/vm/stack_frame.h:273: Thread* thread = Thread::Current())
Pass in only thread and get isolate from thread->isolate(), here and elsewhere

[siva, 2015-10-20 21:06:14]

https://chromiumcodereview.appspot.com/1411703004/diff/1/runtime/vm/stack_fra...
File runtime/vm/stack_frame.h (right):

https://chromiumcodereview.appspot.com/1411703004/diff/1/runtime/vm/stack_fra...
runtime/vm/stack_frame.h:186: Thread* thread = Thread::Current());
The explicit should have been removed when the isolate parameter was added.

I am wondering if we should get rid of the isolate parameter totally here and
derive isolate from thread_->isolate(), having both isolate and thread parameter
seems redundant and provides a possibility of getting these to be inconsistent.

[Cutch, 2015-10-20 21:26:22]

Description was changed from

==========
Pass Thread into StackFrameIterator

BUG=
==========

to

==========
Pass Thread into StackFrameIterator

- StackFrameIterator is now constructed with a Thread instead of an Isolate.
- Profiler provides Thread to StackFrameIterator- allowing this to work on
Windows.
==========

[Cutch, 2015-10-20 21:29:00]

PTAL

[siva, 2015-10-20 21:33:17]

lgtm

[srdjan, 2015-10-20 21:33:47]

lgtm

https://codereview.chromium.org/1411703004/diff/20001/runtime/vm/stack_frame.cc
File runtime/vm/stack_frame.cc (right):

https://codereview.chromium.org/1411703004/diff/20001/runtime/vm/stack_frame....
runtime/vm/stack_frame.cc:273: uword exit_marker =
thread_->top_exit_frame_info();
Please sync with my temporary fix and remove Isolate::top_exit_frame_info()

https://codereview.chromium.org/1411703004/diff/20001/runtime/vm/stack_frame....
runtime/vm/stack_frame.cc:297: Thread* thread)
One line.

[Cutch, 2015-10-20 21:39:01]

https://codereview.chromium.org/1411703004/diff/20001/runtime/vm/stack_frame.cc
File runtime/vm/stack_frame.cc (right):

https://codereview.chromium.org/1411703004/diff/20001/runtime/vm/stack_frame....
runtime/vm/stack_frame.cc:273: uword exit_marker =
thread_->top_exit_frame_info();
On 2015/10/20 21:33:47, srdjan wrote:
> Please sync with my temporary fix and remove Isolate::top_exit_frame_info()

Done.

https://codereview.chromium.org/1411703004/diff/20001/runtime/vm/stack_frame....
runtime/vm/stack_frame.cc:297: Thread* thread)
On 2015/10/20 21:33:47, srdjan wrote:
> One line.

Done.

[Cutch, 2015-10-21 14:37:26]

Committed patchset #5 (id:80001) manually as
24ceded4e9412483ee557afab30ec570a02ec11f (presubmit successful).