Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: runtime/vm/profiler.cc

Issue 1411703004: Pass Thread into StackFrameIterator (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/stack_frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler.cc
diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc
index 1515eed45563e78c82a360e9283be5a103d0b259..d8bed39239c2c90222bb80d9005561308f1e1b5b 100644
--- a/runtime/vm/profiler.cc
+++ b/runtime/vm/profiler.cc
@@ -469,11 +469,12 @@ class ProfilerStackWalker : public ValueObject {
// Given an exit frame, walk the Dart stack.
class ProfilerDartExitStackWalker : public ProfilerStackWalker {
public:
- ProfilerDartExitStackWalker(Isolate* isolate,
+ ProfilerDartExitStackWalker(Thread* thread,
+ Isolate* isolate,
Sample* sample,
SampleBuffer* sample_buffer)
: ProfilerStackWalker(isolate, sample, sample_buffer),
- frame_iterator_(isolate) {
+ frame_iterator_(thread) {
}
void walk() {
@@ -1052,7 +1053,8 @@ void Profiler::RecordAllocation(Thread* thread, intptr_t cid) {
sample_buffer,
OSThread::GetCurrentThreadId());
sample->SetAllocationCid(cid);
- ProfilerDartExitStackWalker dart_exit_stack_walker(isolate,
+ ProfilerDartExitStackWalker dart_exit_stack_walker(thread,
+ isolate,
sample,
sample_buffer);
dart_exit_stack_walker.walk();
@@ -1154,7 +1156,8 @@ void Profiler::RecordSampleInterruptCallback(
fp,
sp);
- ProfilerDartExitStackWalker dart_exit_stack_walker(isolate,
+ ProfilerDartExitStackWalker dart_exit_stack_walker(thread,
+ isolate,
sample,
sample_buffer);
« no previous file with comments | « no previous file | runtime/vm/stack_frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698