chrome/browser/notifications/platform_notification_service_impl.cc - Issue 1411653004: Remove last usage functions from HostContentSettingsMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 1411653004: Remove last usage functions from HostContentSettingsMap Base URL: https://chromium.googlesource.com/chromium/src.git@simplify-host-content-settings

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_browsertest.cc ('k') | chrome/browser/notifications/platform_notification_service_unittest.cc » ('j') | chrome/browser/permissions/permission_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_impl.cc

diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc

index 04734d10174cc6a3e0742d56480536bf374d35ba..c9dcf9177adbecc223c2c6137c46f6d847fd920c 100644

--- a/chrome/browser/notifications/platform_notification_service_impl.cc

+++ b/chrome/browser/notifications/platform_notification_service_impl.cc

@@ -262,9 +262,6 @@ void PlatformNotificationServiceImpl::DisplayNotification(

base::Bind(&CancelNotification,

notification.delegate_id(),

NotificationUIManager::GetProfileID(profile));

- HostContentSettingsMapFactory::GetForProfile(profile)->UpdateLastUsage(

- origin, origin, CONTENT_SETTINGS_TYPE_NOTIFICATIONS);

}

void PlatformNotificationServiceImpl::DisplayPersistentNotification(

@@ -295,9 +292,6 @@ void PlatformNotificationServiceImpl::DisplayPersistentNotification(

GetNotificationUIManager()->Add(notification, profile);

content::RecordAction(

base::UserMetricsAction("Notifications.Persistent.Shown"));

- HostContentSettingsMapFactory::GetForProfile(profile)->UpdateLastUsage(

- origin, origin, CONTENT_SETTINGS_TYPE_NOTIFICATIONS);

}

void PlatformNotificationServiceImpl::ClosePersistentNotification(