chrome/browser/permissions/permission_manager.cc - Issue 1411653004: Remove last usage functions from HostContentSettingsMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_manager.cc

Issue 1411653004: Remove last usage functions from HostContentSettingsMap Base URL: https://chromium.googlesource.com/chromium/src.git@simplify-host-content-settings

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_context_base.cc ('k') | chrome/browser/push_messaging/push_messaging_permission_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_manager.cc

diff --git a/chrome/browser/permissions/permission_manager.cc b/chrome/browser/permissions/permission_manager.cc

index d83e12ebd2bafe951f595b83768df06470f7f362..fe1ec2ced948f624b11ca62ddb4decbbf7c50f87 100644

--- a/chrome/browser/permissions/permission_manager.cc

+++ b/chrome/browser/permissions/permission_manager.cc

@@ -339,10 +339,7 @@ void PermissionManager::RegisterPermissionUsage(PermissionType permission,

if (IsConstantPermission(permission))

return;

- HostContentSettingsMapFactory::GetForProfile(profile_)->UpdateLastUsage(

- requesting_origin,

- embedding_origin,

- PermissionTypeToContentSetting(permission));

+ // TODO(tsergeant): Use this for measuring permission usage stats.

mlamouri (slow - plz ping) 2015/11/09 20:33:13 I'm confused. How is that method not used if it is

raymes 2015/11/09 23:07:58 What I'm trying to say is that the usage informati

}

int PermissionManager::SubscribePermissionStatusChange(