Merge to XFA: Introduce CPDFPageFromFPFDPage()

Merge to XFA: Introduce CPDFPageFromFPFDPage()

Original Review URL: https://codereview.chromium.org/1406543004 .
(cherry picked from commit 943ea142b6a7e6edc91fe3c307013129e6eb0ef3)

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/db0be96179f0cd5f1787564cbccf86320a4d54ae

[Tom Sepez, 2015-10-16 00:18:55]

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cpp
File fpdfsdk/src/fpdfformfill.cpp (left):

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cp...
fpdfsdk/src/fpdfformfill.cpp:121: CPDF_Page* pPage = (CPDF_Page*)page;
And this would be a bug in xfa.

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cpp
File fpdfsdk/src/fpdfformfill.cpp (right):

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cp...
fpdfsdk/src/fpdfformfill.cpp:272: CPDF_Page* pPage = CPDFPageFromFPDFPage(page);
wrong, fix it.

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cp...
fpdfsdk/src/fpdfformfill.cpp:604: if (!hHandle)
wrong, fix.

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdftext.cpp
File fpdfsdk/src/fpdftext.cpp (right):

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdftext.cpp#ne...
fpdfsdk/src/fpdftext.cpp:20: if (!pPage)
wrong, fix.

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfview.cpp#ne...
fpdfsdk/src/fpdfview.cpp:112: CPDF_Page* CPDFPageFromFPDFPage(FPDF_PAGE page) {
fixed.

[Lei Zhang, 2015-10-16 01:23:55]

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cpp
File fpdfsdk/src/fpdfformfill.cpp (left):

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cp...
fpdfsdk/src/fpdfformfill.cpp:121: CPDF_Page* pPage = (CPDF_Page*)page;
On 2015/10/16 00:18:55, Tom Sepez wrote:
> And this would be a bug in xfa.

I wonder why wrote that code... Hmmmm!

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cpp
File fpdfsdk/src/fpdfformfill.cpp (right):

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cp...
fpdfsdk/src/fpdfformfill.cpp:276: CPDFXFA_Document* pDocument =
((CPDFXFA_Page*)pPage)->GetDocument();
No more C-style casts.

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cp...
fpdfsdk/src/fpdfformfill.cpp:604: if (!hHandle)
On 2015/10/16 00:18:55, Tom Sepez wrote:
> wrong, fix.

We are ok with a NULL |page| ?

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfview.cpp#ne...
fpdfsdk/src/fpdfview.cpp:112: CPDF_Page* CPDFPageFromFPDFPage(FPDF_PAGE page) {
On 2015/10/16 00:18:55, Tom Sepez wrote:
> fixed.

Wait, why do we have 2 impls in this file now?

[Tom Sepez, 2015-10-16 16:58:54]

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cpp
File fpdfsdk/src/fpdfformfill.cpp (right):

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfformfill.cp...
fpdfsdk/src/fpdfformfill.cpp:604: if (!hHandle)
On 2015/10/16 01:23:55, Lei Zhang wrote:
> On 2015/10/16 00:18:55, Tom Sepez wrote:
> > wrong, fix.
> 
> We are ok with a NULL |page| ?

No, fixed.

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdftext.cpp
File fpdfsdk/src/fpdftext.cpp (right):

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdftext.cpp#ne...
fpdfsdk/src/fpdftext.cpp:20: if (!pPage)
On 2015/10/16 00:18:55, Tom Sepez wrote:
> wrong, fix.

reverted.

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1411623002/diff/1/fpdfsdk/src/fpdfview.cpp#ne...
fpdfsdk/src/fpdfview.cpp:112: CPDF_Page* CPDFPageFromFPDFPage(FPDF_PAGE page) {
On 2015/10/16 01:23:55, Lei Zhang wrote:
> On 2015/10/16 00:18:55, Tom Sepez wrote:
> > fixed.
> 
> Wait, why do we have 2 impls in this file now?
Twas deleted.

[Tom Sepez, 2015-10-16 17:03:49]

PTAL at PS3.

[Lei Zhang, 2015-10-16 20:20:28]

https://codereview.chromium.org/1411623002/diff/40001/fpdfsdk/src/fpdfformfil...
File fpdfsdk/src/fpdfformfill.cpp (right):

https://codereview.chromium.org/1411623002/diff/40001/fpdfsdk/src/fpdfformfil...
fpdfsdk/src/fpdfformfill.cpp:272: CPDFXFA_Page* pPage = (CPDFXFA_Page*)pPage;
This is wrong still?

[Tom Sepez, 2015-10-16 20:38:45]

https://codereview.chromium.org/1411623002/diff/40001/fpdfsdk/src/fpdfformfil...
File fpdfsdk/src/fpdfformfill.cpp (right):

https://codereview.chromium.org/1411623002/diff/40001/fpdfsdk/src/fpdfformfil...
fpdfsdk/src/fpdfformfill.cpp:272: CPDFXFA_Page* pPage = (CPDFXFA_Page*)pPage;
ugh. Done.

[Lei Zhang, 2015-10-16 20:58:44]

lgtm

[Tom Sepez, 2015-10-16 21:00:26]

Committed patchset #5 (id:80001) manually as
db0be96179f0cd5f1787564cbccf86320a4d54ae (presubmit successful).