Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1406543004: Introduce CPDFPageFromFPDFPage() (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce CPDFPageFromFPFDPage() Abstracts the way that pages are passed to the embedder between XFA and master. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/943ea142b6a7e6edc91fe3c307013129e6eb0ef3

Patch Set 1 #

Patch Set 2 : Fix layering. #

Patch Set 3 : remove unchanged files. #

Patch Set 4 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -90 lines) Patch
M fpdfsdk/include/fsdk_define.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_progressive.cpp View 1 3 chunks +8 lines, -14 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 6 chunks +6 lines, -10 lines 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 2 3 3 chunks +11 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfeditimg.cpp View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 2 3 7 chunks +10 lines, -18 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 2 3 7 chunks +26 lines, -18 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 1 chunk +7 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 2 3 6 chunks +20 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, for review, just like the other one.
5 years, 2 months ago (2015-10-14 23:27:49 UTC) #1
Tom Sepez
Actually adding reviewer.
5 years, 2 months ago (2015-10-14 23:29:51 UTC) #3
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-14 23:52:14 UTC) #4
Tom Sepez
On 2015/10/14 23:52:14, Lei Zhang wrote: > lgtm Lei, please take a quick sanity check ...
5 years, 2 months ago (2015-10-15 22:15:55 UTC) #5
Tom Sepez
5 years, 2 months ago (2015-10-15 23:34:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
943ea142b6a7e6edc91fe3c307013129e6eb0ef3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698