src/IceInstX8664.cpp - Issue 1411583007: Combine allocas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX8664.cpp

Issue 1411583007: Combine allocas (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix a typo. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceInstX8664.cpp

diff --git a/src/IceInstX8664.cpp b/src/IceInstX8664.cpp

index 5c96aeafc37af2841dfcd943e1ee27d551a5e16d..639094d361aa33634a8c90bd48f2adb8562607c2 100644

--- a/src/IceInstX8664.cpp

+++ b/src/IceInstX8664.cpp

@@ -170,7 +170,10 @@ void MachineTraits<TargetX8664>::X86OperandMem::dump(const Cfg *Func,

MachineTraits<TargetX8664>::Address

MachineTraits<TargetX8664>::X86OperandMem::toAsmAddress(

- MachineTraits<TargetX8664>::Assembler *Asm) const {

+ MachineTraits<TargetX8664>::Assembler *Asm,

+ Ice::TargetLowering *Target) const {

+ // TODO(sehr): handle rematerializable base/index.

Jim Stichnoth 2015/11/11 17:39:44 Can you add asserts against rematerializable varia

sehr 2015/11/11 22:14:10 Done.

+ (void)Target;

int32_t Disp = 0;

AssemblerFixup *Fixup = nullptr;

// Determine the offset (is it relocatable?)