Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/BUILD.gn

Issue 1411563004: Add standard "Must be after no_chromium_code" comment in GN files. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/BUILD.gn
diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn
index f6358147be3549b1748905237f1e5a5cd580409d..e9e50cd0b9ed2c5535b17be3b75c2dec43322cbb 100644
--- a/third_party/BUILD.gn
+++ b/third_party/BUILD.gn
@@ -46,6 +46,7 @@ static_library("fx_freetype") {
configs += [
"//build/config/compiler:no_chromium_code",
"//third_party/pdfium:pdfium_config",
+ # Must be after no_chromium_code for warning flags to be ordered correctly.
":fx_freetype_warnings",
]
defines = [ "FT2_BUILD_LIBRARY" ]
@@ -95,6 +96,7 @@ source_set("fx_agg") {
configs += [
"//build/config/compiler:no_chromium_code",
"//third_party/pdfium:pdfium_config",
+ # Must be after no_chromium_code for warning flags to be ordered correctly.
":fx_agg_warnings",
]
sources = [
@@ -134,6 +136,7 @@ source_set("fx_lcms2") {
configs += [
"//build/config/compiler:no_chromium_code",
"//third_party/pdfium:pdfium_config",
+ # Must be after no_chromium_code for warning flags to be ordered correctly.
":fx_lcms2_warnings",
]
sources = [
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698