BUILD.gn - Issue 1411563004: Add standard "Must be after no_chromium_code" comment in GN files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1411563004: Add standard "Must be after no_chromium_code" comment in GN files. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index abd189b8ebe63c0a01ac5afd70118af5f565f418..6accde5b3f24ec28b8a1e973d9bad7b87e706470 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -554,8 +554,7 @@ static_library("fxge") {

configs += [

":pdfium_config",

"//build/config/compiler:no_chromium_code",

- # As of this writing, this needs to be last to suppress a -Wswitch warning.

- # https://crbug.com/547906

+ # Must be after no_chromium_code for warning flags to be ordered correctly.

":fxge_warnings",

]

« no previous file with comments | « no previous file | third_party/BUILD.gn » ('j') | no next file with comments »