chrome/browser/ui/views/toolbar/toolbar_button.h - Issue 1411523009: Adds OnClickCanceled callback to views::Button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.h

Issue 1411523009: Adds OnClickCanceled callback to views::Button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds NotifyReleasedWithoutClick callback to views::Button (one more case handled) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/toolbar_button.h

diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.h b/chrome/browser/ui/views/toolbar/toolbar_button.h

index a9d7b84dffb77dd469eb50859ec122f122874d4b..9526915aa226e7ac4a048f9127499bd26cb4288f 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_button.h

+++ b/chrome/browser/ui/views/toolbar/toolbar_button.h

@@ -66,6 +66,7 @@ class ToolbarButton : public views::LabelButton,

// views::LabelButton:

bool ShouldEnterPushedState(const ui::Event& event) override;

void NotifyClick(const ui::Event& event) override;

+ void OnClickCanceled(const ui::Event& event) override;

// Returns if menu should be shown. Override this to change default behavior.

virtual bool ShouldShowMenu();

@@ -90,7 +91,7 @@ class ToolbarButton : public views::LabelButton,

// Indicates if menu is currently showing.

bool menu_showing_;

- // Y position of mouse when left mouse button is pressed

+ // Y position of mouse when left mouse button is pressed.

int y_position_on_lbuttondown_;

// Menu runner to display drop down menu.