Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2609)

Unified Diff: ui/views/controls/button/button.h

Issue 1411523009: Adds OnClickCanceled callback to views::Button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds NotifyReleasedWithoutClick callback to views::Button (one more case handled) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/button/button.h
diff --git a/ui/views/controls/button/button.h b/ui/views/controls/button/button.h
index 84ca047b145c2fb26d65db01a8473cc36098de28..9dbb4f1286f0cc30a6f223fa9afca8f74e91688f 100644
--- a/ui/views/controls/button/button.h
+++ b/ui/views/controls/button/button.h
@@ -69,6 +69,12 @@ class VIEWS_EXPORT Button : public View {
// Cause the button to notify the listener that a click occurred.
virtual void NotifyClick(const ui::Event& event);
+ // Called when a button gets released without triggering an action or when
+ // a NOTIFY_ON_PRESS button is pressed with a wrong mouse button.
Peter Kasting 2015/12/01 02:03:18 It's not intuitive why we should fire "canceled" f
varkha 2015/12/01 19:23:29 Done. Thinking a bit more we should not really nee
+ // Note: This is only wired up for mouse button events and not gesture
+ // events.
+ virtual void OnClickCanceled(const ui::Event& event);
+
// The button's listener. Notified when clicked.
ButtonListener* listener_;

Powered by Google App Engine
This is Rietveld 408576698