ipc/attachment_broker_privileged_mac.cc - Issue 1411523006: mac: Make Mach port scopers better ScopedGenerics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/attachment_broker_privileged_mac.cc

Issue 1411523006: mac: Make Mach port scopers better ScopedGenerics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/attachment_broker_privileged_mac.cc

diff --git a/ipc/attachment_broker_privileged_mac.cc b/ipc/attachment_broker_privileged_mac.cc

index 29e78334cb47ce78058973cc1197ee786b04f18f..0eb65a0241f6d7a8548f57a02592afe299cc8671 100644

--- a/ipc/attachment_broker_privileged_mac.cc

+++ b/ipc/attachment_broker_privileged_mac.cc

@@ -231,7 +231,8 @@ mach_port_name_t AttachmentBrokerPrivilegedMac::CreateIntermediateMachPort(

send_right_type);

// This call takes ownership of |send_once_right|.

- kr = SendMachPort(send_once_right, port_to_insert, MACH_MSG_TYPE_COPY_SEND);

+ kr = SendMachPort(

+ send_once_right, port_to_insert.get(), MACH_MSG_TYPE_COPY_SEND);

if (kr != KERN_SUCCESS) {

// TODO(erikchen): UMA metric.

mach_port_deallocate(task_port, endpoint);