Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1411503011: devtools: drop Shell.serve_local_directory(). (Closed)

Created:
5 years, 1 month ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

devtools: drop Shell.serve_local_directory(). This is a convenience wrapper over Shell.serve_local_directories(), causing more code duplication and burden when changing the interface than convenience. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c53f07fda77985d212de1bceafdb5ae9bfe2fcf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -40 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 1 chunk +0 lines, -10 lines 0 comments Download
M mojo/devtools/common/devtoolslib/linux_shell.py View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell.py View 1 chunk +0 lines, -21 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments.py View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ppi
Hi Ben, ptal.
5 years, 1 month ago (2015-11-09 12:24:28 UTC) #1
qsr
lgtm
5 years, 1 month ago (2015-11-09 13:09:41 UTC) #2
ppi
5 years, 1 month ago (2015-11-09 13:13:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c53f07fda77985d212de1bceafdb5ae9bfe2fcf6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698