Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: mojo/devtools/common/devtoolslib/android_shell.py

Issue 1411503011: devtools: drop Shell.serve_local_directory(). (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/devtools/common/devtoolslib/linux_shell.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/android_shell.py
diff --git a/mojo/devtools/common/devtoolslib/android_shell.py b/mojo/devtools/common/devtoolslib/android_shell.py
index ab03bb2b5e61fd0725dd34c17a17c36be683fa3d..9dc018dda9536558fb654070a0fd7396baf0371a 100644
--- a/mojo/devtools/common/devtoolslib/android_shell.py
+++ b/mojo/devtools/common/devtoolslib/android_shell.py
@@ -421,16 +421,6 @@ class AndroidShell(Shell):
logcat_watch_thread.start()
@overrides(Shell)
- def serve_local_directory(self, local_dir_path, port=0, free_host_port=False):
- assert local_dir_path
- mappings = [('', [local_dir_path])]
- host_port = 0 if free_host_port else port
- server_address = start_http_server(mappings, host_port=host_port)
-
- return 'http://127.0.0.1:%d/' % self._forward_device_port_to_host(
- port, server_address[1])
-
- @overrides(Shell)
def serve_local_directories(self, mappings, port=0, free_host_port=False):
assert mappings
host_port = 0 if free_host_port else port
« no previous file with comments | « no previous file | mojo/devtools/common/devtoolslib/linux_shell.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698