Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1411503005: Aura on Android: content/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_select_file
Patch Set: Addressing remaining feedback, cleaning up build files. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 60cde3c90ba93d5af5382a035301acccaf634e05..0774fba054a57828fd7bd5c24675e69da204baaa 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -81,7 +81,7 @@ struct LoadNotificationDetails;
struct ResourceRedirectDetails;
struct ResourceRequestDetails;
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
class WebContentsAndroid;
#endif
@@ -127,7 +127,7 @@ class CONTENT_EXPORT WebContentsImpl
// Returns the SavePackage which manages the page saving job. May be NULL.
SavePackage* save_package() const { return save_package_.get(); }
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
// In Android WebView, the RenderView needs created even there is no
// navigation entry, this allows Android WebViews to use
// javascript: URLs that load into the DOMWindow before the first page
@@ -379,9 +379,10 @@ class CONTENT_EXPORT WebContentsImpl
void ResumeMediaSession() override;
void SuspendMediaSession() override;
void StopMediaSession() override;
-
+#if !defined(USE_AURA)
base::android::ScopedJavaLocalRef<jobject> GetJavaWebContents() override;
virtual WebContentsAndroid* GetWebContentsAndroid();
+#endif // !USE_AURA
#elif defined(OS_MACOSX)
void SetAllowOtherViews(bool allow) override;
bool GetAllowOtherViews() override;
@@ -850,7 +851,7 @@ class CONTENT_EXPORT WebContentsImpl
const gfx::Rect& selection_rect,
int active_match_ordinal,
bool final_update);
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
void OnFindMatchRectsReply(int version,
mfomitchev 2015/11/03 22:23:20 @sievers: What is this used for exactly? Should we
no sievers 2015/11/04 01:59:32 find-in-page. This will work differently with Aur
const std::vector<gfx::RectF>& rects,
const gfx::RectF& active_rect);
@@ -1207,7 +1208,7 @@ class CONTENT_EXPORT WebContentsImpl
// this overrides |preferred_size_|.
gfx::Size preferred_size_for_capture_;
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
// Date time chooser opened by this tab.
// Only used in Android since all other platforms use a multi field UI.
scoped_ptr<DateTimeChooserAndroid> date_time_chooser_;

Powered by Google App Engine
This is Rietveld 408576698