Aura on Android: content/browser

content/browser/web_contents/web_contents_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 63 matching lines @@
 class WebContentsObserver;
 class WebContentsView;
 class WebContentsViewDelegate;
 struct AXEventNotificationDetails;
 struct ColorSuggestion;
 struct FaviconURL;
 struct LoadNotificationDetails;
 struct ResourceRedirectDetails;
 struct ResourceRequestDetails;
 
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
 class WebContentsAndroid;
 #endif
 
 // Factory function for the implementations that content knows about. Takes
 // ownership of |delegate|.
 WebContentsView* CreateWebContentsView(
     WebContentsImpl* web_contents,
     WebContentsViewDelegate* delegate,
     RenderViewHostDelegateView** render_view_host_delegate_view);
 
@@ skipping 25 matching lines @@
   // This returns the routing ID of the newly created swapped out RenderView.
   int CreateSwappedOutRenderView(SiteInstance* instance);
 
   // Complex initialization here. Specifically needed to avoid having
   // members call back into our virtual functions in the constructor.
   virtual void Init(const WebContents::CreateParams& params);
 
   // Returns the SavePackage which manages the page saving job. May be NULL.
   SavePackage* save_package() const { return save_package_.get(); }
 
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
   // In Android WebView, the RenderView needs created even there is no
   // navigation entry, this allows Android WebViews to use
   // javascript: URLs that load into the DOMWindow before the first page
   // load. This is not safe to do in any context that a web page could get a
   // reference to the DOMWindow before the first page load.
   bool CreateRenderViewForInitialEmptyDocument();
 #endif
 
   // Expose the render manager for testing.
   // TODO(creis): Remove this now that we can get to it via FrameTreeNode.
@@ skipping 231 matching lines @@
   bool WasRecentlyAudible() override;
   void GetManifest(const GetManifestCallback& callback) override;
   void HasManifest(const HasManifestCallback& callback) override;
   void ExitFullscreen() override;
   void ResumeLoadingCreatedWebContents() override;
 #if defined(OS_ANDROID)
   void OnMediaSessionStateChanged();
   void ResumeMediaSession() override;
   void SuspendMediaSession() override;
   void StopMediaSession() override;
-
+#if !defined(USE_AURA)
   base::android::ScopedJavaLocalRef<jobject> GetJavaWebContents() override;
   virtual WebContentsAndroid* GetWebContentsAndroid();
+#endif  // !USE_AURA
 #elif defined(OS_MACOSX)
   void SetAllowOtherViews(bool allow) override;
   bool GetAllowOtherViews() override;
 #endif
 
   // Implementation of PageNavigator.
   WebContents* OpenURL(const OpenURLParams& params) override;
 
   // Implementation of IPC::Sender.
   bool Send(IPC::Message* message) override;
@@ skipping 448 matching lines @@
                                  const base::string16& title,
                                  bool user_gesture);
   void OnUnregisterProtocolHandler(const std::string& protocol,
                                    const GURL& url,
                                    bool user_gesture);
   void OnFindReply(int request_id,
                    int number_of_matches,
                    const gfx::Rect& selection_rect,
                    int active_match_ordinal,
                    bool final_update);
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
   void OnFindMatchRectsReply(int version,

[mfomitchev, 2015/11/03 22:23:20]

@sievers: What is this used for exactly? Should we create a crbug?

[no sievers, 2015/11/04 01:59:32]

find-in-page.

This will work differently with Aura and it won't need this code, so I think
it's exactly right to ifdef it out here for now.

                              const std::vector<gfx::RectF>& rects,
                              const gfx::RectF& active_rect);
 
   void OnOpenDateTimeDialog(

[mfomitchev, 2015/11/03 22:23:20]

@sievers: Should we create a separate bug for this? Or roll it into the popup
windows bug (do we have one)?

[no sievers, 2015/11/04 01:59:32]

same as above. this will go through a popup created from RWHVAura instead.

       const ViewHostMsg_DateTimeDialogValue_Params& value);
 #endif
   void OnDomOperationResponse(const std::string& json_string);
   void OnAppCacheAccessed(const GURL& manifest_url, bool blocked_by_policy);
   void OnOpenColorChooser(int color_chooser_id,
                           SkColor color,
                           const std::vector<ColorSuggestion>& suggestions);
   void OnEndColorChooser(int color_chooser_id);
   void OnSetSelectedColorInColorChooser(int color_chooser_id, SkColor color);
   void OnWebUISend(const GURL& source_url,
@@ skipping 331 matching lines @@
   int minimum_zoom_percent_;
   int maximum_zoom_percent_;
 
   // The intrinsic size of the page.
   gfx::Size preferred_size_;
 
   // The preferred size for content screen capture.  When |capturer_count_| > 0,
   // this overrides |preferred_size_|.
   gfx::Size preferred_size_for_capture_;
 
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && !defined(USE_AURA)
   // Date time chooser opened by this tab.
   // Only used in Android since all other platforms use a multi field UI.
   scoped_ptr<DateTimeChooserAndroid> date_time_chooser_;
 #endif
 
   // Holds information about a current color chooser dialog, if one is visible.
   struct ColorChooserInfo {
     ColorChooserInfo(int render_process_id,
                      int render_frame_id,
                      ColorChooser* chooser,
@@ skipping 115 matching lines @@
   // Adds/removes a callback called on creation of each new WebContents.
   static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
   static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
 
   DISALLOW_COPY_AND_ASSIGN(FriendZone);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_