Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 141143007: Revert of Revert "Moved text decoding to the parser thread" (Closed)

Created:
6 years, 11 months ago by oystein (OOO til 10th of July)
Modified:
6 years, 11 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, kinuko+watch, aandrey+blink_chromium.org, caseq+blink_chromium.org, bemjb+rendering_chromium.org, yurys+blink_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, nessy, loislo+blink_chromium.org, zoltan1, sof, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, paulirish+reviews_chromium.org, Nate Chapin, vcarbune.chromium, philipj_slow, alph+blink_chromium.org, gasubic, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Revert "Moved text decoding to the parser thread" (https://codereview.chromium.org/133273007/) Reason for revert: High confidence of having identified the cause of the crash now, will apply that in second changelist. Original issue's description: > Revert "Moved text decoding to the parser thread" > > This reverts 164797 > > R=abarth@chromium.org,eseidel@chromium.org > BUG=329603 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165102 TBR=abarth@chromium.org,eseidel@chromium.org NOTREECHECKS=true NOTRY=true BUG=329603 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165488

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -813 lines) Patch
M Source/core/core.gypi View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.cpp View 1 4 chunks +11 lines, -19 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 5 chunks +14 lines, -13 lines 0 comments Download
M Source/core/dom/DocumentEncodingData.h View 1 1 chunk +21 lines, -9 lines 0 comments Download
A + Source/core/dom/DocumentEncodingData.cpp View 1 1 chunk +12 lines, -16 lines 0 comments Download
M Source/core/dom/DocumentParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/DocumentResource.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FontResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ScriptResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ShaderResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
D Source/core/fetch/TextResourceDecoder.h View 1 1 chunk +0 lines, -105 lines 0 comments Download
D Source/core/fetch/TextResourceDecoder.cpp View 1 1 chunk +0 lines, -437 lines 0 comments Download
M Source/core/fetch/XSLStyleSheetResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLBaseElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.h View 1 6 chunks +11 lines, -8 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.cpp View 1 4 chunks +44 lines, -0 lines 0 comments Download
M Source/core/html/parser/CSSPreloadScanner.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 5 chunks +51 lines, -14 lines 0 comments Download
M Source/core/html/parser/HTMLMetaCharsetParser.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/html/parser/HTMLMetaCharsetParser.cpp View 1 3 chunks +9 lines, -89 lines 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.cpp View 1 2 chunks +90 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTokenizer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTokenizer.cpp View 1 2 chunks +11 lines, -10 lines 0 comments Download
M Source/core/html/parser/HTMLViewSourceParser.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/parser/TextDocumentParser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/TextDocumentParser.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/parser/TextResourceDecoder.h View 1 2 chunks +2 lines, -1 line 0 comments Download
A + Source/core/html/parser/TextResourceDecoder.cpp View 1 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 1 5 chunks +32 lines, -22 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/NetworkResourcesData.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentWriter.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/loader/TextResourceDecoderBuilder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerScriptLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
oystein (OOO til 10th of July)
Created Revert of Revert "Moved text decoding to the parser thread"
6 years, 11 months ago (2014-01-17 18:52:44 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-17 18:52:51 UTC) #2
abarth-chromium
This poor patch. :( LGTM
6 years, 11 months ago (2014-01-18 08:56:53 UTC) #3
oystein (OOO til 10th of July)
On 2014/01/18 08:56:53, abarth wrote: > This poor patch. :( > > LGTM Thanks Adam, ...
6 years, 11 months ago (2014-01-21 18:28:34 UTC) #4
abarth-chromium
On 2014/01/21 18:28:34, Oystein wrote: > About https://codereview.chromium.org/133173003/, should I fold those changes > into ...
6 years, 11 months ago (2014-01-21 21:41:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oysteine@chromium.org/141143007/1
6 years, 11 months ago (2014-01-21 21:53:18 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/inspector/NetworkResourcesData.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-21 21:53:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oysteine@chromium.org/141143007/210001
6 years, 11 months ago (2014-01-21 23:24:42 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 23:25:45 UTC) #9
Message was sent while issue was closed.
Change committed as 165488

Powered by Google App Engine
This is Rietveld 408576698