Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: Source/core/dom/DecodedDataDocumentParser.cpp

Issue 141143007: Revert of Revert "Moved text decoding to the parser thread" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/DecodedDataDocumentParser.h ('k') | Source/core/dom/Document.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 10 matching lines...) Expand all
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/dom/DecodedDataDocumentParser.h" 27 #include "core/dom/DecodedDataDocumentParser.h"
28 28
29 #include "core/dom/Document.h" 29 #include "core/dom/Document.h"
30 #include "core/dom/DocumentEncodingData.h" 30 #include "core/dom/DocumentEncodingData.h"
31 #include "core/fetch/TextResourceDecoder.h" 31 #include "core/html/parser/TextResourceDecoder.h"
32 32
33 namespace WebCore { 33 namespace WebCore {
34 34
35 DecodedDataDocumentParser::DecodedDataDocumentParser(Document* document) 35 DecodedDataDocumentParser::DecodedDataDocumentParser(Document* document)
36 : DocumentParser(document) 36 : DocumentParser(document)
37 , m_hasAppendedData(false) 37 , m_needsDecoder(true)
38 { 38 {
39 } 39 }
40 40
41 DecodedDataDocumentParser::~DecodedDataDocumentParser() 41 DecodedDataDocumentParser::~DecodedDataDocumentParser()
42 { 42 {
43 } 43 }
44 44
45 void DecodedDataDocumentParser::setDecoder(PassOwnPtr<TextResourceDecoder> decod er) 45 void DecodedDataDocumentParser::setDecoder(PassOwnPtr<TextResourceDecoder> decod er)
46 { 46 {
47 // If the decoder is explicitly unset rather than having ownership
48 // transferred away by takeDecoder(), we need to make sure it's recreated
49 // next time data is appended.
50 m_needsDecoder = !decoder;
47 m_decoder = decoder; 51 m_decoder = decoder;
48 } 52 }
49 53
50 TextResourceDecoder* DecodedDataDocumentParser::decoder() 54 TextResourceDecoder* DecodedDataDocumentParser::decoder()
51 { 55 {
52 return m_decoder.get(); 56 return m_decoder.get();
53 } 57 }
54 58
55 void DecodedDataDocumentParser::setHasAppendedData() 59 PassOwnPtr<TextResourceDecoder> DecodedDataDocumentParser::takeDecoder()
56 { 60 {
57 m_hasAppendedData = true; 61 return m_decoder.release();
58 } 62 }
59 63
60 void DecodedDataDocumentParser::appendBytes(const char* data, size_t length) 64 void DecodedDataDocumentParser::appendBytes(const char* data, size_t length)
61 { 65 {
62 if (!length) 66 if (!length)
63 return; 67 return;
64 68
65 // This should be checking isStopped(), but XMLDocumentParser prematurely 69 // This should be checking isStopped(), but XMLDocumentParser prematurely
66 // stops parsing when handling an XSLT processing instruction and still 70 // stops parsing when handling an XSLT processing instruction and still
67 // needs to receive decoded bytes. 71 // needs to receive decoded bytes.
(...skipping 16 matching lines...) Expand all
84 // We have nothing to do in that case. 88 // We have nothing to do in that case.
85 if (!m_decoder) 89 if (!m_decoder)
86 return; 90 return;
87 91
88 String remainingData = m_decoder->flush(); 92 String remainingData = m_decoder->flush();
89 updateDocument(remainingData); 93 updateDocument(remainingData);
90 } 94 }
91 95
92 void DecodedDataDocumentParser::updateDocument(String& decodedData) 96 void DecodedDataDocumentParser::updateDocument(String& decodedData)
93 { 97 {
94 DocumentEncodingData encodingData; 98 document()->setEncodingData(DocumentEncodingData(*m_decoder.get()));
95 encodingData.encoding = m_decoder->encoding();
96 encodingData.wasDetectedHeuristically = m_decoder->encodingWasDetectedHeuris tically();
97 encodingData.sawDecodingError = m_decoder->sawError();
98 document()->setEncodingData(encodingData);
99 99
100 if (decodedData.isEmpty()) 100 if (!decodedData.isEmpty())
101 return; 101 append(decodedData.releaseImpl());
102
103 append(decodedData.releaseImpl());
104 // FIXME: Should be removed as part of https://code.google.com/p/chromium/is sues/detail?id=319643
105 if (!m_hasAppendedData) {
106 m_hasAppendedData = true;
107 if (m_decoder->encoding().usesVisualOrdering())
108 document()->setVisuallyOrdered();
109 }
110 } 102 }
111 103
112 }; 104 };
OLDNEW
« no previous file with comments | « Source/core/dom/DecodedDataDocumentParser.h ('k') | Source/core/dom/Document.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698